fix: remove duplicate spacing in log lines#14632
Open
nightcityblade wants to merge 1 commit intokestra-io:developfrom
Open
fix: remove duplicate spacing in log lines#14632nightcityblade wants to merge 1 commit intokestra-io:developfrom
nightcityblade wants to merge 1 commit intokestra-io:developfrom
Conversation
The log header had both flexbox gap (.5rem) and margin-left (1rem) on sibling elements, causing inconsistent/wrong spacing. The gap property alone is sufficient for consistent spacing in a flex container. Fixes kestra-io#14287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the wrong spacing in log lines reported in #14287.
Problem
The log line header (
.headerinLogLine.vue) had both:gap: .5rem(flexbox gap)margin-left: 1remon sibling elements (.header > * + *)These two spacing mechanisms stacked, causing inconsistent and excessive spacing between log header elements (level badge, timestamp, metadata).
Fix
Removed the redundant
margin-leftrule. The flexboxgapproperty alone provides consistent spacing between all child elements.Fixes #14287