fix: improve Labels filter UX (#14512)#14634
Open
sanjay78632 wants to merge 1 commit intokestra-io:developfrom
Open
fix: improve Labels filter UX (#14512)#14634sanjay78632 wants to merge 1 commit intokestra-io:developfrom
sanjay78632 wants to merge 1 commit intokestra-io:developfrom
Conversation
- Always show 'Active Key/Value Pairs' section - Display 'none' when no labels are selected - Always show 'Add' button (previously conditional) - Add counter at bottom showing number of selected labels - Fix capitalization consistency (Key/Value) - Improve button UX with disabled state Fixes kestra-io#14512
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
This PR improves the UX of the Labels filter component to provide clearer feedback when no labels are selected, making it consistent with other filters like the Namespace filter.
Changes made:
🔗 Related Issue
Closes #14512
🎨 Frontend Checklist
npm run build)npm run test:e2e)🛠️ Backend Checklist
This PR does not include any backend changes.
📝 Additional Notes
Before:
After:
Testing:
![Uploading ss_1.png…]()
Tested locally at
http://localhost:5173- the filter now clearly indicates when no labels are selected and provides better visual feedback throughout the label selection process.