Skip to content

fix(test): don't emit replay execution from TestRunnerUtils.awaitChil…#14926

Merged
brian-mulier-p merged 2 commits intodevelopfrom
fix/execution-controller-runner-flaky-tests
Mar 4, 2026
Merged

fix(test): don't emit replay execution from TestRunnerUtils.awaitChil…#14926
brian-mulier-p merged 2 commits intodevelopfrom
fix/execution-controller-runner-flaky-tests

Conversation

@brian-mulier-p
Copy link
Member

…dExecution

@brian-mulier-p brian-mulier-p requested review from a team and Skraye March 4, 2026 16:00
@github-project-automation github-project-automation bot moved this to To review in Pull Requests Mar 4, 2026
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

🐋 Docker image

ghcr.io/kestra-io/kestra-pr:14926
docker run --pull=always --rm -it -p 8080:8080 --user=root -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/tmp ghcr.io/kestra-io/kestra-pr:14926 server local

🧪 Java Unit Tests

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
Java Tests Report4010 ran3996 ✅13 ⚠️1 ❌41m 28s 443ms
TestResultTime ⏱
Java Tests Report
PostgresQueueTest.noGroup()❌ failure5s 143ms

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Tests report quick summary:

failed ❌ > tests: 4010, success: 3996, skipped: 13, failed: 1

Project Status Success Skipped Failed
cli success ✅ 80 0 0
core success ✅ 1958 0 0
executor success ✅ 4 0 0
jdbc success ✅ 11 0 0
jdbc-h2 success ✅ 473 0 0
jdbc-mysql success ✅ 476 0 0
jdbc-postgres failed ❌ 475 0 1
processor success ✅ 7 0 0
runner-memory success ✅ 1 0 0
scheduler success ✅ 23 0 0
script success ✅ 12 0 0
storage-local success ✅ 64 0 0
webserver success ✅ 421 0 0
worker success ✅ 4 0 0

Failed tests:

jdbc-postgres > io.kestra.runner.postgres.PostgresQueueTest > noGroup() failed ❌ in 5.143
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.kestra.jdbc.runner.JdbcQueueTest.noGroup(JdbcQueueTest.java:53)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:154)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:171)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:128)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:141)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1450)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2019)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)


Develocity build scan: https://develocity.kestra.io/s/qouqwffgcjnza

@brian-mulier-p brian-mulier-p force-pushed the fix/execution-controller-runner-flaky-tests branch from a2935e5 to af7807f Compare March 4, 2026 16:28
@brian-mulier-p brian-mulier-p force-pushed the fix/execution-controller-runner-flaky-tests branch from af7807f to 6b8ff5f Compare March 4, 2026 16:35
@brian-mulier-p brian-mulier-p merged commit 1ef729d into develop Mar 4, 2026
13 of 15 checks passed
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Mar 4, 2026
@brian-mulier-p brian-mulier-p deleted the fix/execution-controller-runner-flaky-tests branch March 4, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants