Skip to content

Refactor Engine config access to unified pattern#35

Merged
kettasoft merged 11 commits intomasterfrom
refactor/engine-refactoring
Nov 14, 2025
Merged

Refactor Engine config access to unified pattern#35
kettasoft merged 11 commits intomasterfrom
refactor/engine-refactoring

Conversation

@kettasoft
Copy link
Owner

This PR refactors the abstract Engine class to unify how configuration values are accessed across all engine subclasses.

  • Updated methods like getOperatorsFromConfig, isIgnoredEmptyValuesFromConfig, getAllowedFieldsFromConfig, isStrictFromConfig to use a consistent pattern:

    return config("filterable.engines.{$this->getEngineName()}.<key>", <default>);
  • Removed unused imports from the Engine abstract class.

  • Simplifies maintenance and avoids repeated boilerplate for fetching engine-specific configuration.

This refactor does not change runtime behavior, only standardizes the configuration access pattern.

@kettasoft kettasoft self-assigned this Nov 14, 2025
@kettasoft kettasoft merged commit 36547ae into master Nov 14, 2025
1 check passed
@kettasoft kettasoft deleted the refactor/engine-refactoring branch November 14, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant