Conversation
⚡️ A message from a fellow meat-based-AI ⚡️ - [❤️] Finely-crafted open-source tools like token-resolver (& many more) require time and effort. - [❤️] Though I adore my work, it lacks financial sustainability. - [❤️] Please, help me continue enhancing your tools by becoming a sponsor: - [💲] https://liberapay.com/pboling/donate - [💲] https://github.com/sponsors/pboling
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Pull request overview
Prepares the v1.0.0 release by updating development dependencies, regenerating/publishing YARD documentation, and adjusting CI/test + coverage tasks to support the release workflow.
Changes:
- Bumped dev/test/release toolchain gems (e.g.,
kettle-dev,kettle-test,stone_checksums) and updatedGemfile.lockaccordingly. - Regenerated/added YARD HTML documentation under
docs/. - Introduced a custom
rake magicspec task and updated GitHub Actions workflows to run it; adjusted coverage thresholds.
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
| token-resolver.gemspec | Updates development dependency versions/constraints. |
| Gemfile.lock | Locks updated versions for bumped tooling gems. |
| Rakefile | Adds rake magic RSpec task + rewires coverage task. |
| .github/workflows/current.yml | Switches CI command from rake test to rake magic. |
| .github/workflows/coverage.yml | Lowers coverage thresholds; switches to rake magic. |
| .github/workflows/heads.yml | Switches CI command from rake test to rake magic. |
| .github/workflows/dep-heads.yml | Switches CI command from rake test to rake magic. |
| .github/workflows/supported.yml | Switches CI command from rake test to rake magic. |
| .github/workflows/legacy.yml | Switches CI command from rake test to rake magic. |
| .github/workflows/truffle.yml | Switches CI command from rake test to rake magic. |
| CHANGELOG.md | Updates release section to 1.0.0 and adds release metadata/links. |
| README.md | Updates copyright year and KLOC badge value. |
| docs/index.html | Adds generated YARD “File: README” page (release docs). |
| docs/top-level-namespace.html | Adds generated YARD top-level namespace page. |
| docs/method_list.html | Adds generated YARD method list page. |
| docs/file_list.html | Adds generated YARD file list page. |
| docs/file.CHANGELOG.html | Updates generated YARD changelog page (includes release section). |
| docs/file.CITATION.html | Adds generated YARD CITATION page. |
| docs/file.FUNDING.html | Adds generated YARD FUNDING page. |
| docs/file.CONTRIBUTING.html | Updates generated YARD CONTRIBUTING page timestamp/content. |
| docs/file.CODE_OF_CONDUCT.html | Updates generated YARD CODE_OF_CONDUCT page timestamp/content. |
| docs/file.SECURITY.html | Updates generated YARD SECURITY page timestamp/content. |
| docs/file.resolver.html | Updates generated YARD resolver page timestamp/content. |
| docs/Token.html | Updates generated YARD Token module page timestamp/content. |
| docs/Token/Resolver.html | Adds generated YARD Token::Resolver module page. |
| docs/Token/Resolver/Config.html | Adds generated YARD Config class page. |
| docs/Token/Resolver/Resolve.html | Adds generated YARD Resolve class page. |
| docs/Token/Resolver/Transform.html | Updates generated YARD Transform page timestamp/content. |
| docs/Token/Resolver/Version.html | Adds generated YARD Version module page. |
| docs/Token/Resolver/Error.html | Adds generated YARD base Error page. |
| docs/Token/Resolver/UnresolvedTokenError.html | Adds generated YARD UnresolvedTokenError page. |
| docs/Token/Resolver/Node/Text.html | Adds generated YARD Node::Text class page. |
| docs/Token/Resolver/Node/Token.html | Adds generated YARD Node::Token class page. |
| docs/file.AGENTS.html | Removes generated YARD AGENTS page. |
| docs/file.REEK.html | Removes generated YARD REEK page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <li id="object_AGENTS" class="odd"> | ||
| <div class="item"><span class="object_link"><a href="file.AGENTS.html" title="AGENTS">AGENTS</a></span></div> | ||
| </li> |
There was a problem hiding this comment.
The docs file list includes an entry for AGENTS, but docs/file.AGENTS.html is currently empty/missing content, so this link will render a blank page. Either include the generated AGENTS doc page content (regenerate docs) or remove AGENTS from the published YARD file list.
| <li id="object_REEK" class="odd"> | ||
| <div class="item"><span class="object_link"><a href="file.REEK.html" title="REEK">REEK</a></span></div> | ||
| </li> |
There was a problem hiding this comment.
The docs file list links to REEK, but docs/file.REEK.html is currently empty/missing content, so this link will render a blank page. Either restore/regenerate the REEK documentation page or remove this entry from the published YARD file list.
| - ruby: "ruby-3.4" | ||
| appraisal: "ruby-3-4" | ||
| exec_cmd: "rake test" | ||
| exec_cmd: "rake magic" |
There was a problem hiding this comment.
This workflow now runs rake magic, which is a custom task defined in Rakefile only when rspec/core/rake_task loads successfully. If rspec is missing/disabled for a runtime in the matrix, CI will fail with an undefined task. Either ensure :magic is always defined (even as a stub) or keep workflows calling an always-available task (e.g., rake test/rake spec).
| - ruby: "ruby-head" | ||
| appraisal: "head" | ||
| exec_cmd: "rake test" | ||
| exec_cmd: "rake magic" |
There was a problem hiding this comment.
This workflow now runs rake magic, which is a custom task defined in Rakefile only when rspec/core/rake_task loads successfully. If rspec is missing/disabled for a runtime in the matrix, CI will fail with an undefined task. Either ensure :magic is always defined (even as a stub) or keep workflows calling an always-available task (e.g., rake test/rake spec).
| - ruby: "truffleruby-head" | ||
| appraisal: "head" | ||
| exec_cmd: "rake test" | ||
| exec_cmd: "rake magic" |
There was a problem hiding this comment.
This workflow now runs rake magic, which is a custom task defined in Rakefile only when rspec/core/rake_task loads successfully. If rspec is missing/disabled for a runtime in the matrix, CI will fail with an undefined task. Either ensure :magic is always defined (even as a stub) or keep workflows calling an always-available task (e.g., rake test/rake spec).
| [1.0.0]: https://github.com/kettle-rb/ast-merge/compare/e0e299cad6e6914d512845c71df6b7ac8009e5ac...v1.0.0 | ||
| [1.0.0t]: https://github.com/kettle-rb/ast-merge/tags/v1.0.0 |
There was a problem hiding this comment.
The 1.0.0 release links at the bottom point to the kettle-rb/ast-merge repository, which appears unrelated to this gem (token-resolver). This will send users to the wrong compare view/tag; update these URLs to the token-resolver repo (or whatever canonical remote you intend to publish releases from).
| [1.0.0]: https://github.com/kettle-rb/ast-merge/compare/e0e299cad6e6914d512845c71df6b7ac8009e5ac...v1.0.0 | |
| [1.0.0t]: https://github.com/kettle-rb/ast-merge/tags/v1.0.0 | |
| [1.0.0]: https://github.com/kettle-rb/token-resolver/compare/e0e299cad6e6914d512845c71df6b7ac8009e5ac...v1.0.0 | |
| [1.0.0t]: https://github.com/kettle-rb/token-resolver/tags/v1.0.0 |
| - ruby: "truffleruby-25.0" | ||
| appraisal: "ruby-3-2" | ||
| exec_cmd: "rake test" | ||
| exec_cmd: "rake magic" |
There was a problem hiding this comment.
This workflow now runs rake magic, which is a custom task defined in Rakefile only when rspec/core/rake_task loads successfully. If rspec is missing/disabled for a runtime in the matrix, CI will fail with an undefined task. Either ensure :magic is always defined (even as a stub) or keep workflows calling an always-available task (e.g., rake test/rake spec).
| exec_cmd: "rake magic" | |
| exec_cmd: "rake spec" |
| - ruby: "ruby-3.3" | ||
| appraisal: "ruby-3-3" | ||
| exec_cmd: "rake test" | ||
| exec_cmd: "rake magic" |
There was a problem hiding this comment.
This workflow now runs rake magic, which is a custom task defined in Rakefile only when rspec/core/rake_task loads successfully. If rspec is missing/disabled for a runtime in the matrix, CI will fail with an undefined task. Either ensure :magic is always defined (even as a stub) or keep workflows calling an always-available task (e.g., rake test/rake spec).
| - ruby: "jruby" | ||
| appraisal: "current" | ||
| exec_cmd: "rake test" | ||
| exec_cmd: "rake magic" |
There was a problem hiding this comment.
This workflow now runs rake magic, which is a custom task defined in Rakefile only when rspec/core/rake_task loads successfully. If rspec is missing/disabled for a runtime in the matrix, CI will fail with an undefined task. Either ensure :magic is always defined (even as a stub) or keep workflows calling an always-available task (e.g., rake test/rake spec).
No description provided.