DONOTMERGE: zkevm-benchmark-workload repo #8
Conversation
|
Your PR title doesn't follow the Conventional Commit guidelines. Example of valid titles:
Usage:
Breaking Changes Breaking changes are noted by using an exclamation mark. For example:
Help For more information, follow the guidelines here: https://www.conventionalcommits.org/en/v1.0.0/ |
|
Going to add back Forkspec because ChainSpec is not serializable and currently its quite a bit of work to get that going |
Co-authored-by: Roman Krasiuk <[email protected]>
|
TODO: ClientInput still accepts a RecoveredBlock |
kevaundray
force-pushed
the
kw/zkevm-benchmark-workload-repo
branch
from
7463154 to
d026cee
Compare
Use ChainConfig for stateless block validation
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Add partial witness support
Signed-off-by: Ignacio Hagopian <[email protected]>
fmt to reduce diff noise
| EMPTY_WITHDRAWALS, HOLESKY_GENESIS_HASH, HOODI_GENESIS_HASH, MAINNET_GENESIS_HASH, | ||
| SEPOLIA_GENESIS_HASH, | ||
| }, | ||
| Header, |
There was a problem hiding this comment.
Changes in this file are related to the opened issue https://github.com/ethereum/execution-spec-tests/issues/2031
| Ok(BlockExecutionOutput { state: state.take_bundle(), result }) | ||
| } | ||
|
|
||
| /// Executes the EVM with the given input and accepts a state closure that is always invoked |
There was a problem hiding this comment.
Required for invalid block execution witnes-gen/proving
| #[macro_export] | ||
| macro_rules! track_cycles { | ||
| ($name:expr, $body:expr) => {{ | ||
| #[cfg(target_os = "zkvm")] | ||
| { | ||
| tracing::info!("cycle-tracker-report-start: {}", $name); | ||
| let result = $body; | ||
| tracing::info!("cycle-tracker-report-end: {}", $name); | ||
| result | ||
| } | ||
|
|
||
| #[cfg(not(target_os = "zkvm"))] | ||
| $body | ||
| }}; |
There was a problem hiding this comment.
This change, and the ones in the next file are mainly SP1 track cycle instrumentation.
I usually find these cycles tracking for SP1 helpful to quickly see optimizations impact, etc. But from another angle, cycles for some kind of optimizations are quite brittle. They're only meaningful for non-crypto related opts.
Prob these changes will never be upstreamed as they are. I guess we could think about creating a trait that can be provided for instrumentation, and the client can impl for different zkVMs -- but definitely is the last upstream effort I would leave pending (if ever happens). 😅
cc @kevaundray if you have any thought
| //! Test runners for `BlockchainTests` in <https://github.com/ethereum/tests> | ||
| use crate::{ | ||
| models::{BlockchainTest, ForkSpec}, |
There was a problem hiding this comment.
Remaining changes in this files are mainly the invalid block feature (i.e., returning partial witnesses), and very initial feature of running tests returning witnesses.
|
Documented a bit the current set of changes:
Left PR comments with some pointers or extra details. |
Signed-off-by: Ignacio Hagopian <[email protected]>
Update reth fork
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Fork update
No description provided.