Skip to content

Apply date format to IDescriptable #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevbite merged 1 commit into from
Dec 6, 2024
Merged

Apply date format to IDescriptable #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CompaniesHouse/Description/IDescriptable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
{
public interface IDescriptable
{
string GetDescription(string format);
string GetDescription(string format, string dateFormat = null);
}
}
4 changes: 2 additions & 2 deletions src/CompaniesHouse/Response/CompanyFiling/FilingHistoryItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ public class FilingHistoryItem : IDescriptable
[JsonProperty(PropertyName = "links")]
public Links Links { get; set; }

public string GetDescription(string format)
public string GetDescription(string format, string dateFormat = null)
{
return DescriptionProvider.GetDescription(format, DescriptionValues);
return DescriptionProvider.GetDescription(format, DescriptionValues, dateFormat);
}
}
}
4 changes: 2 additions & 2 deletions src/CompaniesHouse/Response/CompanyFiling/FilingHistoryItemAnnotation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ public class FilingHistoryItemAnnotation : IDescriptable
[JsonProperty(PropertyName = "description_values")]
private JObject DescriptionValues { get; set; }

public string GetDescription(string format)
public string GetDescription(string format, string dateFormat = null)
{
return DescriptionProvider.GetDescription(format, DescriptionValues);
return DescriptionProvider.GetDescription(format, DescriptionValues, dateFormat);
}
}
}
4 changes: 2 additions & 2 deletions src/CompaniesHouse/Response/CompanyFiling/FilingHistoryItemResolution.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ public class FilingHistoryItemResolution : IDescriptable
[JsonProperty(PropertyName = "description_values")]
private JObject DescriptionValues { get; set; }

public string GetDescription(string format)
public string GetDescription(string format, string dateFormat = null)
{
return DescriptionProvider.GetDescription(format, DescriptionValues);
return DescriptionProvider.GetDescription(format, DescriptionValues, dateFormat);
}
}
}
Loading