Skip to content

httpbin_secure: fix redirect Location to have "https://" scheme #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin1024 merged 1 commit into from
Dec 25, 2021
Merged

httpbin_secure: fix redirect Location to have "https://" scheme #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pytest_httpbin/serve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def finish_request(self, request, client_address):
server_side=True,
suppress_ragged_eofs=False,
)
self.base_environ['HTTPS'] = 'yes'
self.RequestHandlerClass(ssock, client_address, self)
except Exception as e:
print("pytest-httpbin server hit an exception serving request: %s" % e)
Expand Down
11 changes: 11 additions & 0 deletions tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,14 @@ def test_fixed_port_environment_variables(protocol):
del os.environ[envvar]
else:
os.environ[envvar] = envvar_original


def test_redirect_location_is_https_for_secure_server(httpbin_secure):
assert httpbin_secure.url.startswith('https://')
response = requests.get(
httpbin_secure + "/redirect-to?url=/html",
allow_redirects=False
)
assert response.status_code == 302
assert response.headers.get('Location')
assert response.headers['Location'].startswith('https://')