Draft
Conversation
… if the paremeter is removed from the ECF
…h if the paremeter is removed from the ECF
Most models seem to work well now (polynomial, exponential ramp, and centroid have specifically been tested). The celerite2.jax GP model is currently failing, but it is also failing in the same way on the celerite2 docs pages, so I don't think that's an issue on my end.
taylorbell57
added this to
Road to v2.0, Stage 5: Light Curve Fitting and Performance improvement
github-project-automation
bot
moved this to In progress
in Stage 5: Light Curve Fitting
Still having an issue where scatter_mult or scatter_ppm don't get fitted, however
Works for uniform eclipse and limb-darkened transit, but Ylm variables seem to be ignored. Haven't tested starspots yet
Collaborator
Author
|
Reminding myself here that I can/should make progress on #591 in this PR |
At present, preliminary testing shows they're as fast or perhaps a bit faster, even without jitting anything. I will look into adding one or multiple @jit calls which may speed things up further. But the main benefit will be the reduction in duplication of code between non-jax and with-jax setups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because starry+PyMC3 are now so outdated that we can no longer maintain support for them, I am quickly working to add jax+jaxoplanet support.
This is just a draft PR to help make sure others know this feature is getting added soon, and I'll mark it as ready for review once it is.
This PR will resolve #170 and resolve #310