Open
Conversation
a231fde to
f2cc5b7
Compare
773bf1e to
00ce459
Compare
This was referenced Feb 1, 2026
Open
Author
|
Btw, if you want to hop on a quick call to review this PR (and/or help me understand what other things need to be built), feel free to DM me @suis_siva |
00ce459 to
78198b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all.
This PR adds support for Anchor 0.32.1. I mostly based my work off of #163 but I tried to improve the code quality a little bit and also ensure all tests pass.
Note: I was unable to find the source/IDLs for a lot of the existing test IDLs. Consequently, I have deleted some test IDLs. I would urge you figure out how to find those source files again, and drop the relevant commit (read further).
Prior to merge:
pyproject.tomlto our version.Validation
Type Checks
Tests
I had a little bit of trouble running
make testsincesolana-test-validatorwasn't properly cleaned up on my machine so I ran the tests manually, pkilling the validator. I didn't bother to investigate the validator persiting after test execution. The warnings I got probably hint at the issue, but that's way beyond the scope of this PR.kevinheavey/anchorpy-idl#5 changes
Three key changes:
IdlTypeDefined::definedwhich was declared as public in the.pyiIdlDefinedFieldsNamediterable in the python code, so that the legacy API could still be used inanchorpy. My reasoning was that doing this minimizes the blast radius in this repo.docsconstructors to acceptNonewhere the.pyispecified.