support adls.token

[kevinjqliu]

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

[kevinjqliu]

/gemini review

[gemini-code-assist]

Summary of Changes

Hello @kevinjqliu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces direct token-based authentication support for Azure Data Lake Storage (ADLS) connections. It enhances the flexibility of ADLS authentication by allowing users to provide a raw token string, which is then used to establish a secure connection. This new method complements existing authentication options like SAS tokens and general credentials, streamlining access for various ADLS use cases.

Highlights

• New ADLS Token Constant: A new constant ADLS_TOKEN has been added to pyiceberg/io/__init__.py to represent the configuration key for the ADLS authentication token.
• Token-based ADLS Authentication: The _adls function in pyiceberg/io/fsspec.py has been updated to accept and utilize an adls.token property. This involves the creation of a StaticTokenCredential class to wrap the provided token, allowing it to be used with adlfs for authentication.
• Credential Prioritization: The authentication logic for ADLS now prioritizes the adls.token if present, falling back to adls.credential if the token is not provided.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for adls.token for authenticating with Azure Data Lake Storage. The implementation is a good step forward. I've provided a couple of suggestions to improve the code's robustness and readability. Specifically, I've recommended refactoring the credential selection logic to be more concise and to correctly handle edge cases, and replacing a magic number with a named constant for better maintainability.

[gemini-code-assist]

Code Review

This pull request adds support for adls.token for authenticating with Azure Data Lake Storage. The implementation introduces a StaticTokenCredential helper class to wrap the provided token.

My review focuses on the new credential handling logic. I've identified a potential bug where providing adls.token as None can prevent fallback to adls.credential, and I've suggested a fix. I also have a suggestion to make the token expiration time configurable for better flexibility, instead of using a hardcoded value.

[kevinjqliu]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for adls.token for ADLS authentication, which is a valuable addition. The implementation of StaticTokenCredential has a potential issue with token expiration that could affect long-running applications, for which I've provided a specific comment with a suggested fix. It would also be beneficial to add tests for this new authentication method to ensure its correctness and prevent future regressions.

[kevinjqliu]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for authenticating with Azure Data Lake Storage using a token via the adls.token property. The implementation adds a helper class StaticTokenCredential within the _adls function to wrap the static token. While the implementation appears correct, it is missing unit tests to verify the new authentication path. Adding tests is crucial to ensure the feature works as intended and to prevent regressions.

[gemini-code-assist]

This change introduces new authentication logic for ADLS using adls.token, but it lacks corresponding unit tests. To ensure the correctness and maintainability of this feature, please add a test case in tests/io/test_fsspec.py. The test should verify that when adls.token is provided in the properties, AzureBlobFileSystem is initialized with an appropriate credential object that wraps the token.