Skip to content

Conversation

@kevinjqliu
Copy link
Owner

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kevinjqliu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the capabilities of the Azure Blob Storage file system by integrating support for the 'wasb' and 'wasbs' protocols, enhancing its versatility. Concurrently, it optimizes the project's dependency landscape through targeted updates and removals, contributing to a more efficient and focused environment. The changes are thoroughly validated with updated test suites designed to cover the expanded protocol support.

Highlights

  • Azure Blob Storage Protocol Support: Added support for 'wasb' and 'wasbs' protocols within the AzureBlobFileSystem, expanding compatibility for Azure Blob Storage interactions.
  • Dependency Management Refinements: Updated the 'adlfs' dependency to point to a specific git commit, ensuring the use of a particular development version. The 'pyarrow' dependency has also been updated to a newer version. Several packages, including 'bodo', 'cloudpickle', 'impi-rt', 'llvmlite', 'numba', and 'psutil', have been removed from the project's dependencies, streamlining the dependency graph.
  • Enhanced ADLS Test Coverage: Refactored existing Azure Data Lake Storage (ADLS) related tests to utilize a new 'adls_scheme' fixture. This allows for more comprehensive testing across different Azure Blob Storage schemes, including the newly supported 'wasb' and 'wasbs' protocols.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for wasb and wasbs schemes for Azure Blob Storage by overriding AzureBlobFileSystem.protocol. The approach of monkey-patching the protocol list has a bug that makes it non-idempotent, which I've commented on with a suggested fix. There's also a minor bug in a test file.

Additionally, this PR includes significant, and seemingly unrelated, dependency changes. The bodo dependency and its sub-dependencies are removed, and pyarrow is upgraded. It would be beneficial to either move these changes to a separate pull request or update the description to clarify their necessity for this change.

@kevinjqliu kevinjqliu closed this Sep 3, 2025
@kevinjqliu kevinjqliu deleted the christophediprima/main branch November 9, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants