-
Notifications
You must be signed in to change notification settings - Fork 0
Kevinjqliu/run ci windows #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kevinjqliu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating key project dependencies and configurations to align with newer versions. It bumps the PYICEBERG_VERSION to 0.10.0 and updates various development and documentation tools. Additionally, the bug report template has been adjusted to reflect the new 0.10.0 as the latest Apache Iceberg version, ensuring consistency across the project's ecosystem.
Highlights
- PyIceberg Version Update: The
PYICEBERG_VERSIONin thedev/Dockerfilehas been updated from0.9.1to0.10.0. - Dependency Updates: Several development and documentation dependencies in
pyproject.tomlhave been updated, includingpytest-mock,mkdocstrings-python, andmkdocs-material. - Bug Report Template Alignment: The
iceberg_bug_report.ymltemplate has been updated to include0.10.0as the latest Apache Iceberg version option.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project version to 0.10.0 and refreshes several development and documentation dependencies. The changes appear correct and consistent with the version bump. I've added a few suggestions to improve dependency management in pyproject.toml by using caret constraints, which would simplify future updates.
On a separate note, the pull request title 'Kevinjqliu/run ci windows' suggests changes related to Windows CI, but I don't see any such changes in the diff. Could you please clarify if this is intended or if more changes are expected?
| moto = { version = "^5.0.2", extras = ["server"] } | ||
| typing-extensions = "4.15.0" | ||
| pytest-mock = "3.14.1" | ||
| pytest-mock = "3.15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, consider using a caret constraint for this development dependency, like ^3.15.0. This allows poetry update to pull in non-breaking patch and minor updates automatically, ensuring you benefit from bug fixes without manual version bumps. This pattern is already in use for other dependencies like moto and coverage.
| pytest-mock = "3.15.0" | |
| pytest-mock = "^3.15.0" |
| jinja2 = "3.1.6" | ||
| mkdocstrings = "0.30.0" | ||
| mkdocstrings-python = "1.17.0" | ||
| mkdocstrings-python = "1.18.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| mkdocs-autorefs = "1.4.3" | ||
| mkdocs-gen-files = "0.5.0" | ||
| mkdocs-material = "9.6.18" | ||
| mkdocs-material = "9.6.20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To align with modern dependency management practices, it would be beneficial to use a caret constraint for mkdocs-material as well (e.g., ^9.6.20). This ensures that you receive compatible updates automatically, which is especially useful for tools that are frequently updated.
| mkdocs-material = "9.6.20" | |
| mkdocs-material = "^9.6.20" |
f329282 to
8bc2b9b
Compare
8bc2b9b to
f6e09fa
Compare
a284075 to
522771c
Compare
537380f to
0f02755
Compare
Rationale for this change
Surprisingly, not as many errors as I expected
Are these changes tested?
Are there any user-facing changes?