-
Notifications
You must be signed in to change notification settings - Fork 0
try pyiceberg-core 0.7.0rc2 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kevinjqliu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the pyiceberg-core dependency to version 0.7.0rc1. This is reflected in both pyproject.toml and poetry.lock. The change in poetry.lock also includes some reordering of markers, likely due to a change in the poetry version used to generate the lock file. My feedback focuses on the dependency pinning strategy.
pyproject.toml
Outdated
| daft = { version = ">=0.5.0", optional = true } | ||
| cachetools = ">=5.5,<7.0" | ||
| pyiceberg-core = { version = ">=0.5.1,<0.7.0", optional = true } | ||
| pyiceberg-core = { version = "==0.7.0rc1", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning the pyiceberg-core dependency to a specific release candidate (==0.7.0rc1) is suitable for temporary testing, as suggested by the PR title. However, if this change is intended to be merged into a long-lived branch, it's worth considering the risks of depending on a non-stable release. Release candidates can introduce bugs or breaking changes. Once 0.7.0 is officially released, it would be better to update to the stable version, possibly with a more flexible version constraint like ^0.7.0 to allow for compatible updates.
try 0.7.0rc2
3c7d9f6 to
bad624c
Compare
537380f to
0f02755
Compare
Rationale for this change
Are these changes tested?
Are there any user-facing changes?