Skip to content

Conversation

@kevinjqliu
Copy link
Owner

Rationale for this change

Are these changes tested?

Are there any user-facing changes?

@gemini-code-assist
Copy link

Summary of Changes

Hello @kevinjqliu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the pyiceberg-core dependency to its 0.7.0rc1 release candidate. This update is crucial for incorporating the latest advancements and improvements from the core library. The changes primarily involve modifying the version constraint in pyproject.toml and subsequently regenerating the poetry.lock file to align with the new dependency structure and ensure build consistency.

Highlights

  • PyIceberg Core Update: The pyiceberg-core dependency has been updated to its 0.7.0rc1 release candidate version, ensuring the project leverages the latest features and fixes from the core library.
  • Dependency Lock File Regeneration: The poetry.lock file has been regenerated to reflect the updated pyiceberg-core version and other minor reorderings of dependency markers, ensuring consistent and reproducible builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pyiceberg-core dependency to version 0.7.0rc1. This is reflected in both pyproject.toml and poetry.lock. The change in poetry.lock also includes some reordering of markers, likely due to a change in the poetry version used to generate the lock file. My feedback focuses on the dependency pinning strategy.

pyproject.toml Outdated
daft = { version = ">=0.5.0", optional = true }
cachetools = ">=5.5,<7.0"
pyiceberg-core = { version = ">=0.5.1,<0.7.0", optional = true }
pyiceberg-core = { version = "==0.7.0rc1", optional = true }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning the pyiceberg-core dependency to a specific release candidate (==0.7.0rc1) is suitable for temporary testing, as suggested by the PR title. However, if this change is intended to be merged into a long-lived branch, it's worth considering the risks of depending on a non-stable release. Release candidates can introduce bugs or breaking changes. Once 0.7.0 is officially released, it would be better to update to the stable version, possibly with a more flexible version constraint like ^0.7.0 to allow for compatible updates.

try 0.7.0rc2
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/try-pyiceberg-core-0.7.0 branch from 3c7d9f6 to bad624c Compare September 29, 2025 03:39
@kevinjqliu kevinjqliu changed the title try pyiceberg-core 0.7.0rc1 try pyiceberg-core 0.7.0rc2 Sep 29, 2025
@kevinjqliu kevinjqliu force-pushed the main branch 2 times, most recently from 537380f to 0f02755 Compare October 26, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants