Use win32 threadpool for IO events, support control transfer timeouts#171
Draft
kevinmehall wants to merge 3 commits intomainfrom
Draft
Use win32 threadpool for IO events, support control transfer timeouts#171kevinmehall wants to merge 3 commits intomainfrom
kevinmehall wants to merge 3 commits intomainfrom
Conversation
so its pointer can be obtained and used
kevinmehall
force-pushed
the
windows-threadpool
branch
from
7f255f0 to
ed0b7b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#168
Use Windows threadpool APIs for the IOCP event handling instead of our own event loop on a dedicated thread. The Win32 threadpool also provides timers, which can be used to cancel control transfers after a timeout. Like libusb, do our own timeout handling in order to provide each control transfer with its own timeout rather than relying on the globally-configured WinUSB timeout.
Works, but needs cleanup and further testing.