Django 5.1: use mark_safe for PrettyJSONWidget#34
Open
b0uh wants to merge 2 commits intokevinmickey:masterfrom
Open
Django 5.1: use mark_safe for PrettyJSONWidget#34b0uh wants to merge 2 commits intokevinmickey:masterfrom
mark_safe for PrettyJSONWidget#34b0uh wants to merge 2 commits intokevinmickey:masterfrom
Conversation
Author
|
If someone else has this issue, the following snippet is a temporary workaround: from django.utils.safestring import mark_safe
from prettyjson import PrettyJSONWidget
class PrettyJSONWidgetFixed(PrettyJSONWidget):
def render(self, name, value, attrs=None, **kwargs):
return mark_safe(super().render(name, value, attrs=None, **kwargs)) |
|
Would be nice to have this merged |
minchinweb
added a commit
to minchinweb/minchin.django.excel
that referenced
this pull request
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to Django 5.1 we notice that the
PrettyJSONWidgetwas broken in the admin. It seems to be because the HTML code returned is not marked as safe.I tested the behavior locally and also run the tests coming along the projects to be sure I was not breaking anything.
Before
After