Consistently name intrinsic Cluster angles#465
Merged
tmadlener merged 5 commits intokey4hep:mainfrom Dec 11, 2025
Merged
Conversation
Cluster::phi to Cluster::iPhi to make it consistent with iTheta94d7302 to
e38da23
Compare
Member
Author
|
All tests introduced in #467 still work with these changes (once all the necessary changes have landed in podio). |
Member
Author
|
Deprecation warnings for
With the temporary addition of the old methods via |
e38da23 to
d11885f
Compare
3c0b937 to
b1aab0b
Compare
b1aab0b to
1cb874a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Clusterintrinsic phi consistent in naming with intrinsic theta, i.e. renamephitoiPhiENDRELEASENOTES
This currently needs the following PRs / fixes in podio.
ExtraCodefor old schemas when doing schema evolution AIDASoft/podio#890It also builds on top of