Skip to content

Consistently name intrinsic Cluster angles#465

Merged
tmadlener merged 5 commits intokey4hep:mainfrom
tmadlener:cluster-iphi
Dec 11, 2025
Merged

Consistently name intrinsic Cluster angles#465
tmadlener merged 5 commits intokey4hep:mainfrom
tmadlener:cluster-iphi

Conversation

@tmadlener tmadlener changed the title Fix Cluster::phi to Cluster::iPhi to make it consistent with iTheta Consistently name intrinsic Cluster angles Nov 24, 2025
@tmadlener
Copy link
Member Author

All tests introduced in #467 still work with these changes (once all the necessary changes have landed in podio).

@tmadlener
Copy link
Member Author

Deprecation warnings for [g,s]etPhi will appear in

  • k4EDM4hep2LcioConv
  • k4GaudiPandora

With the temporary addition of the old methods via ExtraCode I can build the stack locally with these changes.

@tmadlener tmadlener merged commit 9a1e323 into key4hep:main Dec 11, 2025
7 of 9 checks passed
@tmadlener tmadlener deleted the cluster-iphi branch December 11, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant