Implement kSecAttrGeneric to encode additional credential metadata#113
Open
Benehiko wants to merge 2 commits intokeybase:masterfrom
Open
Implement kSecAttrGeneric to encode additional credential metadata#113Benehiko wants to merge 2 commits intokeybase:masterfrom
Benehiko wants to merge 2 commits intokeybase:masterfrom
Conversation
This patch adds the `kSecAttrGeneric` key so that credentials can store additional publicly available metadata on kSecClassGenericPassword credentials. The caller can add any generic metadata they'd like to store as long as it does not exceed the size of math.MaxUint32. This allows for a wider variety of use cases where many secrets are fetched from the keychain without fetching the underlying secret. Additional filtering rules could apply on the fetch secrets based on the metadata. More information about `kSecAttrGeneric` can be found here https://developer.apple.com/documentation/security/ksecattrgeneric Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
commented
Jul 16, 2025
Comment on lines
+225
to
+226
| enc := gob.NewEncoder(&b) | ||
| if err := enc.Encode(val); err != nil { |
Author
There was a problem hiding this comment.
maybe there's a more efficient way of doing this?
Author
|
|
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the
kSecAttrGenerickey so that credentials can store additional publicly available metadata on kSecClassGenericPassword credentials. The caller can add any generic metadata they'd like to store as long as it does not exceed the size of math.MaxUint32.This allows for a wider variety of use cases where many secrets are fetched from the keychain without fetching the underlying secret. Additional filtering rules could apply on the fetch secrets based on the metadata.
More information about
kSecAttrGenericcan be found here https://developer.apple.com/documentation/security/ksecattrgeneric