Skip to content

Parse unknown, non-critical subpackets as Unknown #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalz-zoom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parse unknown, non-critical subpackets as Unknown #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion lib/openpgp/packet/signature.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions src/openpgp/packet/signature.iced
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,15 @@ class Experimental extends SubPacket

#------------

# Ignore unless critical.
class Unknown extends SubPacket
constructor : (@buf, @type) ->
@parse : (slice, type) ->
new Unknown slice.consume_rest_to_buffer(), type
_v_to_buffer : () -> @buf

#------------

class Time extends SubPacket
constructor : (type, @time) ->
@never_expires = (@time is 0)
Expand Down Expand Up @@ -809,6 +818,7 @@ class Parser
when S.preferred_aead_algos then PreferredAEADAlgorithms
else
if type >= S.experimental_low and type <= S.experimental_high then Experimental
else if not critical then Unknown
else throw new Error "Unknown signature subpacket: #{type}"
ret = klass.parse @slice, type
ret.set_opts { critical, five_byte_len }
Expand Down