Skip to content

Add padding to guides categories and fix layout on phones#716

Merged
ahus1 merged 1 commit intokeycloak:mainfrom
mabartos:guides-layout
Mar 19, 2026
Merged

Add padding to guides categories and fix layout on phones#716
ahus1 merged 1 commit intokeycloak:mainfrom
mabartos:guides-layout

Conversation

@mabartos
Copy link
Contributor

@mabartos mabartos commented Mar 16, 2026

  • Use flex to fix layout on phones
  • Use gap for padding for the version selector and categories list
  • Minimal width for the version selector as on smaller screens, it was shrinked
  • Smaller font size on the secondary navbar as shown in the bootstrap example: https://getbootstrap.com/docs/5.3/examples/offcanvas-navbar/

OLD

Screencast.From.2026-03-16.10-38-50.mp4

NEW

Screencast.From.2026-03-18.10-30-47.mp4

@shawkins @vmuzikar I believe this might be a minimal fix for the layout on phones and the gap... Later, we can discuss this follow-up:

WDYT?

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. I may have misunderstood the original complaint about how things looked - I thought the concern was more about having the categories on multiple lines.

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Copy link
Contributor Author

@shawkins Yes, the concern was about the single line - I thought that we could live with it and just make things nicer...

But, I moved a little bit further and make more changes to be also ~compliant with Bootstrap and secondary navbars. Please take a look.

@mabartos mabartos requested review from ahus1 and shawkins March 18, 2026 09:34
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good. I do prefer having the drop down for categories - especially on mobile.

@ahus1 ahus1 merged commit df2fc7e into keycloak:main Mar 19, 2026
2 checks passed
@mabartos
Copy link
Contributor Author

I do prefer having the drop down for categories - especially on mobile.

Yes, on the mobile, it'd really help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants