fix: Align flow config of OIDC clients with Keycloak defaults

[thomas-VIGINUM]

Current problem

The keycloak_openid_client resource documentation states some arguments defaults, especially on the flow definition. However, those attributes are computed instead of defaulted.

Changes

Move some arguments from Computed to Default.

[sschu]

@thomas-VIGINUM It looks like you didnt hit the correct defaults e.g. standard flow is enabled by default.

[thomas-VIGINUM]

Hey @sschu,

Concerning to the Terraform documentation page, all variables mentioned default to false, even the standard flow. And I think it is nice to keep as the documentation states : by default all flows are disabled, and you have to explicitly enable on your code the different flows.

terraform-provider-keycloak/docs/resources/openid_client.md

Lines 130 to 133 in d06f0b9

	- `standard_flow_enabled` - (Optional) When `true`, the OAuth2 Authorization Code Grant will be enabled for this client. Defaults to `false`.
	- `implicit_flow_enabled` - (Optional) When `true`, the OAuth2 Implicit Grant will be enabled for this client. Defaults to `false`.
	- `direct_access_grants_enabled` - (Optional) When `true`, the OAuth2 Resource Owner Password Grant will be enabled for this client. Defaults to `false`.
	- `service_accounts_enabled` - (Optional) When `true`, the OAuth2 Client Credentials grant will be enabled for this client. Defaults to `false`.

terraform-provider-keycloak/docs/resources/openid_client.md

Line 151 in d06f0b9

- `consent_required` - (Optional) When `true`, users have to consent to client access. Defaults to `false`.

[sschu]

What the documentation says is wrong because the provider is currently just using the Keycloak defaults - which has standard flow enabled. That's why the tests are failing.

[thomasdarimont]

I created an issue for this #1325 think we should indeed fix this.

[thomasdarimont]

@thomas-VIGINUM thanks for your PR! Would you mind rebasing it to latest main and add your DCO (git commit -s ...)?

[thomasdarimont]

With the change from this PR the OIDC client example configuration works correctly:

resource "keycloak_openid_client" "openid_client" {
  realm_id            = keycloak_realm.test.id
  client_id           = "test-client"

  name                = "test client"
  enabled             = true

  access_type         = "CONFIDENTIAL"
  valid_redirect_uris = [
    "http://localhost:8080/openid-callback"
  ]

  login_theme = "keycloak"

  extra_config = {
    "key1" = "value1"
    "key2" = "value2"
  }
}

[thomasdarimont]

... just tried to run the tests locally, as @sschu already wrote this change breaks many tests. I think we have to think a bit more about how we can solve this.