-
Notifications
You must be signed in to change notification settings - Fork 376
Add OAUTH authentication option to SMTP servers #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've tested this locally and everything seems to work, except the |
e5310bb to
e0ae25d
Compare
|
Looks like the |
|
Thanks for your PR. I updated your branch, accidentially pressed merge main instead of rebasing it on main. Feel free to rebase the branch on your side on latest main, then we can see if we can. integrate it this week. |
|
Please ignore what I said in ... #1293 (comment) :) Would it be possible to add 2 additional test-cases similar to the following examples? |
This patch leaves the `auth` argument to `smtp_server` as it is, but adds a new `token_auth` block to let users configure an auth token through Terraform. Implements keycloak#1162 Signed-off-by: Lucy McPhail <[email protected]>
Signed-off-by: Lucy McPhail <[email protected]>
bce7ad7 to
f00f676
Compare
|
Rebased onto main, and I've added those test cases. Let me know if there's anything else we need :) |
|
Thanks @lucymcphail! I'll take it from here and try to get this merged this week. |
thomasdarimont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests. I just gave this a spin. Looks good to me :)
I'll retrigger the build and merge if it passes.
This also fixes #1194.
This patch leaves the
authargument tosmtp_serveras it is, but adds a newtoken_authblock to let users configure an auth token through Terraform.Implements #1162