Conversation
added 5 commits
February 12, 2026 11:21
Signed-off-by: Marek Safarik <msafarik@redhat.com>
Signed-off-by: Marek Safarik <msafarik@redhat.com>
Signed-off-by: Marek Safarik <msafarik@redhat.com>
Signed-off-by: Marek Safarik <msafarik@redhat.com>
Signed-off-by: Marek Safarik <msafarik@redhat.com>
sarroutbi
reviewed
Feb 23, 2026
.github/workflows/golangci-lint.yaml
Outdated
| golangci-lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 |
Collaborator
There was a problem hiding this comment.
Please, use v6 rather than v5 (review all .yaml files and fix this)
sarroutbi
reviewed
Feb 23, 2026
.github/workflows/golangci-lint.yaml
Outdated
| - name: Show Go version | ||
| run: go version | ||
|
|
||
| - name: Install golangci-lint |
Collaborator
There was a problem hiding this comment.
Instead of using go install, try using golangci-lint GH action:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: latest
sarroutbi
requested changes
Feb 23, 2026
…nstall with golangci-lint) Signed-off-by: Marek Safarik <msafarik@redhat.com>
sarroutbi
reviewed
Feb 23, 2026
.github/workflows/golangci-lint.yaml
Outdated
| - name: Run golangci-lint | ||
| run: golangci-lint -v run ./... | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v6 |
Collaborator
There was a problem hiding this comment.
Use v9, as it is the latest one, to check if issues are gone:
https://github.com/golangci/golangci-lint-action/releases
Signed-off-by: Marek Safarik <msafarik@redhat.com>
msafarik
force-pushed
the
actions
branch
4 times, most recently
from
228c76f to
cc589db
Compare
Signed-off-by: Marek Safarik <msafarik@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CI/CD and jobs + fixed failed checks