Skip to content

chore: add version 17 details to language history#1846

Merged
mcdurdin merged 2 commits intomasterfrom
chore/update-language-history
Feb 7, 2025
Merged

chore: add version 17 details to language history#1846
mcdurdin merged 2 commits intomasterfrom
chore/update-language-history

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Feb 7, 2025

No description provided.

@mcdurdin mcdurdin added this to the B18S1 milestone Feb 7, 2025
@mcdurdin mcdurdin added the chore label Feb 7, 2025
@mcdurdin mcdurdin requested a review from darcywong00 February 7, 2025 01:11
* Support for [flick and multi-tap gestures](/developer/current-version/reference/file-types)
in touch layouts
* Support for additional special key caps in
[touch layouts](/developer/current-version/reference/file-types/keyman-touch-layout):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could we include the "Key text" anchor? (the Markdown that corresponds to keyman-touch-layout#toc-key-text)

  2. I understand that current-version is more flexible to apply to future versions. If we pin to 17.0, would that avoid future links breaking? (hypothetically a future Keyman version renames keyman-touch-layout to something else)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. OK
  2. We could, but then we would have to go and update with each release, which is a pain. With current-version, at least the link checker will complain if we move things around.


## Keyman 17

* Support for [flick and multi-tap gestures](/developer/current-version/reference/file-types)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help clarify why gestures links to file-types?

Maybe we add a gestures section after subkey in keyman-touch-layout?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the only reference information for gestures I could find. Also not great, so have updated to the context help for the editor for now.

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Feb 7, 2025

@darcywong00 have addressed review comments

Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit d6a1a97 into master Feb 7, 2025
3 checks passed
@mcdurdin mcdurdin deleted the chore/update-language-history branch February 7, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants