-
-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add search knowledge base title #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Meng-Heng
wants to merge
16
commits into
master
Choose a base branch
from
kb-search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−6
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3e975be
feat: add search knowledge base title
Meng-Heng 9988649
auto: Keyboard help deployment
keyman-server e5b8d77
auto: Keyboard help deployment
keyman-server 0a75304
auto: Keyboard help deployment
keyman-server c43b040
auto: Keyman for developer help deployment
keyman-server 66ccc3e
auto: Keyboard help deployment
keyman-server 8a1f1e5
auto: Keyboard help deployment
keyman-server 452b39a
auto: Keyboard help deployment
keyman-server f13dbe0
auto: Keyboard help deployment
keyman-server 13d72b3
auto: Keyboard help deployment
keyman-server ce515e3
auto: Keyboard help deployment
keyman-server 90c1139
feat: add search value to input and remove javascript
Meng-Heng 8b9de64
Merge branch 'master' into kb-search
Meng-Heng bf073d8
Revert "feat: add search value to input and remove javascript"
Meng-Heng 6754631
feat: add search value to input and remove javascript
Meng-Heng 224b992
feat: move `fclose($handle)`
Meng-Heng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| .search-bar { | ||
| display: flex; | ||
| align-items: center; | ||
| width: 40vw; | ||
| height: 56px; | ||
| padding: 0 10px; | ||
| margin-bottom: 20px; | ||
| margin-left: 10px; | ||
| background-color: #eceef3; | ||
| border: 1px solid gray; | ||
| } | ||
|
|
||
| .search-icon { | ||
| font-size: 20px; | ||
| opacity: 0.6; | ||
| margin-right: 10px; | ||
| } | ||
|
|
||
| .search-bar form { | ||
| width: 100%; | ||
| display: flex; | ||
| flex-direction: row; | ||
| } | ||
|
|
||
| .search-bar input { | ||
| flex: 1; | ||
| background: transparent; | ||
| border: none; | ||
| outline: none; | ||
| font-size: 18px; | ||
| width: 100%; | ||
| padding: 0 10px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to
fclose($handle);before wecontinueso that we don't leak $handle?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. What will be the issue if it is leaked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the worst case the server uses more and more resources and eventually can crash because it runs out of file handles. Whether or not that happens depends on the implementation of the server, how often processes get restarted etc, but leaks always smell.
I'm not that familiar with php and don't know if
fcloseis mainly cosmetic and php does some kind of garbage collection in the background, but if there is afcloseand we call it elsewhere, I'd call it here as well.