refactor(web): remove some aliases 🎼 #15414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
mcdurdin
requested changes
Jan 9, 2026
Comment on lines
4
to
6
| export class Worker { | ||
| static constructInstance(): Worker { | ||
| return new Worker(this.asBlobURI(LMLayerWorkerCode)); | ||
| return new globalThis.Worker(this.asBlobURI(LMLayerWorkerCode)); |
Member
There was a problem hiding this comment.
This is a little problematic. Worker is a generic and semi-reserved name that we should not be stepping on. This should be LMWorker or PredictiveTextWorker, throughout.
(DefaultWorker is also kinda weird)
Addresses code review comment: `Worker` is a generic and semi-reserved name that we should not be stepping on. This renames it to `WebWorker` instead of the suggested `LMWorker` or `PredictiveTextWorker`. `WebWorker` is a name that was already used in a few places and seems to better match: there is a corresponding class for running with node. Naming it `WebWorker` makes it clearer that this is the corresponding class when running in the browser. The corresponding class for running under node was renamed to `NodeWorker`. Test-bot: skip
mcdurdin
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of review comments in #15401.
DefaultWorker(inwebsubfolder) →WebWorkerWorker(innodesubfolder) →NodeWorkerBUTTON_CLASSES→buttonClassNamesAll exports now also match the filenames.
Follow-up-of: #15401
Test-bot: skip