feat: add support for Test-bot: trailer in PR comments#504
Merged
Conversation
The existing `@keymanapp-test-bot` pattern will continue to be supported, but the commit-trailer style `Test-bot: ` matches other controls we use in commit messages and is recommended for use. Note that this trailer is only recognized in PR comments at this time; parsing commit messages may be supported in a future update (but with caution because they are less visible in the PR view and workflow, so may cause confusion to testers). Fixes: keymanapp/keyman#13212
mcdurdin
force-pushed
the
feat/test-bot-trailer
branch
from
1295787 to
783fcc3
Compare
Contributor
|
Does this also get updated in |
Member
Author
Done 😁 |
Member
Author
|
Verified working okay!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
@keymanapp-test-botpattern will continue to be supported, but the commit-trailer styleTest-bot:matches other controls we use in commit messages and is recommended for use.Note that this trailer is only recognized in PR comments at this time; parsing commit messages may be supported in a future update (but with caution because they are less visible in the PR view and workflow, so may cause confusion to testers).
Fixes: keymanapp/keyman#13212