change: show counters on service state#541
Merged
Conversation
This allows us to see how long services have been down for, or attempting to read from service etc. Service timers start showing after 5 seconds for loading state (and update each second), or 3 minutes for successful (loaded) state (and update each minute). For error or unknown states, the timer shows immediately and updates every second. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to see how long services have been down for, or attempting to read from service etc. Service timers start showing after 5 seconds for loading state (and update each second), or 3 minutes for successful (loaded) state (and update each minute). For error or unknown states, the timer shows immediately and updates every second.
Note that this does not show when the last actual change was, because this reflects only the loading state -- so each load attempt will reset the corresponding counter. We may refresh this later for more detail.
Test-bot: skip