Skip to content

fix: use target_url instead of url #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcdurdin merged 1 commit into from
Sep 3, 2025
Merged

fix: use target_url instead of url #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions server/keymanapp-test-bot/artifact-links-comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,31 +59,21 @@ export async function getArtifactLinksComment(
for(let context of Object.keys(s)) {
// artifactLinks
let u;
if(!s[context].url) {
if(!s[context].target_url) {
console.warn(`[@keymanapp-test-bot] skipping ${s[context].context}`);
continue;
}
try {
u = new URL(s[context].url);
u = new URL(s[context].target_url);
} catch(e) {
console.error(`[@keymanapp-test-bot] ${e}`);
continue;
}
if (u.hostname == 'jenkins.lsdev.sil.org') {
for (let download of artifactLinks.jenkinsTarget.downloads) {
if (!links['Linux']) links['Linux'] = [];
links['Linux'].push({
state: s[context].state,
platform: 'Linux',
download: download.name,
url: `${s[context].url}/${download.fragment}`,
});
}
} else if (context == 'Debian Packaging') {
if (context == 'Debian Packaging') {
// https://github.com/keymanapp/keyman/actions/runs/4294449810
const matches = s[context].url.match(/.+\/runs\/(\d+)/);
const matches = s[context].target_url.match(/.+\/runs\/(\d+)/);
if (!matches) {
console.error(`[@keymanapp-test-bot] Can't find workflow run in url ${s[context].url}`);
console.error(`[@keymanapp-test-bot] Can't find workflow run in url ${s[context].target_url}`);
return '';
}
const run_id = matches[1];
Expand Down Expand Up @@ -200,7 +190,7 @@ function findBuildData(s, buildTypeId, teamCity) {
// artifactLinks
let u;
try {
u = new URL(s[context].url);
u = new URL(s[context].target_url);
} catch(e) {
continue;
}
Expand Down