refactor: expand the dialog for scanCode fallback

Author: kamilkrzyskow

app/src/main/java/io/github/sds100/keymapper/mappings/keymaps/trigger/BaseConfigTriggerViewModel.kt

@@ -461,13 +461,17 @@ abstract class BaseConfigTriggerViewModel(
                 return
             }
 
-            val dialog = PopupUi.Ok(
+            val dialog = PopupUi.Dialog(
+                title = getString(R.string.dialog_title_keycode_to_scancode_trigger_explanation),
                 message = getString(R.string.dialog_message_keycode_to_scancode_trigger_explanation),
+                positiveButtonText = getString(R.string.pos_understood),
             )
 
-            showPopup("keycode_to_scancode_message", dialog)
+            val response = showPopup("keycode_to_scancode_message", dialog)
 
-            onboarding.shownKeyCodeToScanCodeTriggerExplanation = true
+            if (response == DialogResponse.POSITIVE) {
+                onboarding.shownKeyCodeToScanCodeTriggerExplanation = true
+            }
         }
 
         if (key.keyCode == KeyEvent.KEYCODE_CAPS_LOCK) {

app/src/main/res/values/strings.xml

@@ -415,7 +415,6 @@
     <string name="dialog_message_cant_find_accessibility_settings_page">Your device doesn\'t seem to have an accessibility services settings page. Tap \"guide\" to read the online guide that explains how to fix this.</string>
     <string name="dialog_message_parallel_trigger_order">The keys need to be listed from top to bottom in the order that they will be held down.</string>
     <string name="dialog_message_sequence_trigger_explanation">A \"sequence\" trigger has a timeout unlike parallel triggers. This means after you press the first key, you will have a set amount of time to input the rest of the keys in the trigger. All the keys that you have added to the trigger won\'t do their usual action until the timeout has been reached. You can change this timeout in the "Options" tab.</string>
-    <string name="dialog_message_keycode_to_scancode_trigger_explanation">The pressed button was not recognized by the input system. In the past Key Mapper detected such buttons as one and the same. Currently the app tries to distinguish the button based on the scan code, which should be more unique. However, this is a makeshift incomplete solution, which doesn\'t guarantee uniqueness.</string>
     <string name="dialog_message_bt_constraint_limitation">Android doesn\'t allow apps to get a list of connected (not paired) Bluetooth devices. Apps can only detect when they are connected and disconnected. So if your Bluetooth device is already connected to your device when the accessibility service starts, you will have to reconnect it for the app to know it is connected.</string>
     <string name="dialog_message_change_location_or_disable">Change location or turn off automatic back up?</string>
     <string name="dialog_message_screen_constraints_limitation">Screen on/off constraints will only work if you have turned on the \"detect trigger when screen is off\" key map option. This option will only show for some keys (e.g volume buttons) and if you are rooted. See a list of supported keys on the Help page.</string>
@@ -493,6 +492,9 @@
     <string name="drag_handle_for">Drag handle for %1$s</string>
     <string name="show_example">Show example</string>
 
+    <string name="dialog_title_keycode_to_scancode_trigger_explanation">Unrecognized key code</string>
+    <string name="dialog_message_keycode_to_scancode_trigger_explanation">The pressed button was not recognized by the input system. In the past Key Mapper detected such buttons as one and the same. Currently the app tries to distinguish the button based on the scan code, which should be more unique. However, this is a makeshift incomplete solution, which doesn\'t guarantee uniqueness.</string>
+
     <string name="pos_done">Done</string>
     <string name="pos_grant_write_secure_settings_guide">Guide</string>
     <string name="pos_start_service_with_adb_guide">Guide</string>
@@ -504,6 +506,7 @@
     <string name="pos_apply">Apply</string>
     <string name="pos_discard_changes">Discard changes</string>
     <string name="pos_save">Save</string>
+    <string name="pos_understood">Understood</string>
 
     <string name="neg_turn_off">Turn off</string>
     <string name="neg_cancel">Cancel</string>