Fix wrong build path when building multiple modules together.#422
Open
GrandZhuo wants to merge 1 commit intokezong:masterfrom
Open
Fix wrong build path when building multiple modules together.#422GrandZhuo wants to merge 1 commit intokezong:masterfrom
GrandZhuo wants to merge 1 commit intokezong:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project information is saved in the DirectoryManager when the plug-in is initialised. However, when there are multiple modules built together, DirectoryManager doesn't sense that the Project has changed, resulting in getting the wrong build path.
So we should pass the information of the currently built Project when we get the build directory, instead of using the initialised Project.