Skip to content

237 any possibility of adding narmfalse argument to the gendatadensity and adddatadensity functions#238

Merged
kgoldfeld merged 10 commits intomainfrom
237-any-possibility-of-adding-narmfalse-argument-to-the-gendatadensity-and-adddatadensity-functions
Jun 27, 2025
Merged

237 any possibility of adding narmfalse argument to the gendatadensity and adddatadensity functions#238
kgoldfeld merged 10 commits intomainfrom
237-any-possibility-of-adding-narmfalse-argument-to-the-gendatadensity-and-adddatadensity-functions

Conversation

@kgoldfeld
Copy link
Owner

@kgoldfeld kgoldfeld commented Jun 27, 2025

No description provided.

@kgoldfeld kgoldfeld linked an issue Jun 27, 2025 that may be closed by this pull request
Any possibility of adding na.rm=FALSE argument to the genDataDensity and addDataDensity functions? #237
Closed
@kgoldfeld
Copy link
Owner Author

kgoldfeld commented Jun 27, 2025

@assignUser Greetings - it has been a while. Hope you are well. I made a quick update to the genDataDensity and addDataDensity functions. I added an na.rm argument that allows users to generate missing data at the same rate that it appears in the distribution definition. I also added some related tests.

I've also made some updates to the workflow configuration - some versions were out of date. You don't need to review if you are too busy.

assignUser
assignUser approved these changes Jun 27, 2025
View reviewed changes
Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, looks great otherwise!

touchstone/config.json
Copy link
Collaborator

@assignUser assignUser Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a frozen snapshot and now it's a moving target so it might cause issues through updates? But I guess it would be good to see those in CI anyway :)

.github/workflows/touchstone-receive.yaml
Comment on lines +15 to +19
{
echo "config<<EOF"
cat ./touchstone/config.json
echo "EOF"
} >> "$GITHUB_OUTPUT"
Copy link
Collaborator

@assignUser assignUser Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Owner Author

@kgoldfeld kgoldfeld Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ChatGPT, not me. :)

@assignUser
Copy link
Collaborator

assignUser commented Jun 27, 2025 •
edited
Loading

it has been a while. Hope you are well.

@kgoldfeld it has, thanks for the ping always happy to review! I've been well, hope you are too!

@kgoldfeld kgoldfeld merged commit 0734ac6 into main Jun 27, 2025
9 checks passed
@kgoldfeld kgoldfeld deleted the 237-any-possibility-of-adding-narmfalse-argument-to-the-gendatadensity-and-adddatadensity-functions branch June 27, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser assignUser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Any possibility of adding na.rm=FALSE argument to the genDataDensity and addDataDensity functions?

2 participants

@kgoldfeld @assignUser