Skip to content

feat(member): 문의 페이지 생성#280

Merged
yummjin merged 64 commits intomainfrom
feature/274
Sep 20, 2025
Merged

feat(member): 문의 페이지 생성#280
yummjin merged 64 commits intomainfrom
feature/274

Conversation

@seoJing
Copy link
Copy Markdown
Contributor

@seoJing seoJing commented May 27, 2025

Summary

#274

문의 페이지의 UI를 구현했습니다.
아직 API 연동은 되어있지 않으며, 시각적인 부분만 완료된 상태입니다.

Tasks

  • 문의 페이지 레이아웃 구성
  • 정적데이터로 예시 화면 생성

Screenshot

@seoJing seoJing requested review from Jeong-Ag and yummjin May 27, 2025 06:18
@seoJing seoJing added ✨ Feature 새로운 기능 명세 및 개발 🏠 Member member 프로젝트 관련 labels May 27, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 27, 2025

⚠️ No Changeset found

Latest commit: cfa90af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (0c66f87) to head (cfa90af).
⚠️ Report is 125 commits behind head on main.

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   94.06%   93.71%   -0.35%     
==========================================
  Files          14       14              
  Lines         219      207      -12     
  Branches       37       38       +1     
==========================================
- Hits          206      194      -12     
  Misses         11       11              
  Partials        2        2              

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@Jeong-Ag Jeong-Ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드량이 많아서 꼼꼼한 리뷰가 어렵네요.... 우선 코멘트 남긴 사항 보완해주시면 추가적으로 더 살펴볼게요
코드 전반적으로 살펴보시면서 self colsing, 구조분해할당, 주석 삭제 적용해주시면 좋을 것 같아요 다 코멘트를 남기긴 그래서 일부만 남겨놨어요~

Copy link
Copy Markdown
Member

@Jeong-Ag Jeong-Ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전에 올라온 PR 보면서 나눠서 커밋해보시는 걸 추천드려요~

@seoJing seoJing marked this pull request as draft August 9, 2025 17:44
@seoJing seoJing marked this pull request as ready for review August 10, 2025 00:52
@seoJing seoJing requested review from Jeong-Ag and yummjin August 10, 2025 00:53
@seoJing seoJing requested a review from Jeong-Ag August 10, 2025 13:11
@kgu-clab kgu-clab deleted a comment from yummjin Sep 20, 2025
@seoJing seoJing requested review from Jeong-Ag and yummjin September 20, 2025 09:33
@Jeong-Ag Jeong-Ag changed the title feat(member): 문의 페이지 UI 스타일 개발 feat(member): 문의 페이지 생성 Sep 20, 2025
@yummjin yummjin merged commit e536380 into main Sep 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 새로운 기능 명세 및 개발 🏠 Member member 프로젝트 관련

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants