-
Notifications
You must be signed in to change notification settings - Fork 2
feature/#185 image resizing 기능 구현 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,4 +34,7 @@ out/ | |
| /.nb-gradle/ | ||
|
|
||
| ### VS Code ### | ||
| .vscode/ | ||
| .vscode/ | ||
|
|
||
| ## file | ||
| /cloud | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...-domain/src/main/java/kgu/developers/domain/file/infrastructure/ImageResizingService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| package kgu.developers.domain.file.infrastructure; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
|
|
||
| public interface ImageResizingService { | ||
| File imageResize(File inputFile, int width, int height, double quality) throws IOException; | ||
| } |
23 changes: 23 additions & 0 deletions
23
...ain/src/main/java/kgu/developers/domain/file/infrastructure/ImageResizingServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package kgu.developers.domain.file.infrastructure; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
|
|
||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import net.coobird.thumbnailator.Thumbnails; | ||
|
|
||
| @Service | ||
| public class ImageResizingServiceImpl implements ImageResizingService { | ||
| public File imageResize(File inputFile, int width, int height, double quality) throws IOException { | ||
| File outputFile = new File(inputFile.getParent(), inputFile.getName()); | ||
|
|
||
| Thumbnails.of(inputFile) | ||
| .size(width, height) | ||
| .outputQuality(quality) | ||
| .keepAspectRatio(true) | ||
| .toFile(outputFile); | ||
|
|
||
| return outputFile; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미지 리사이징 구현 시 몇 가지 개선이 필요합니다.
다음과 같이 수정하는 것을 제안합니다:
public File imageResize(File inputFile, int width, int height, double quality) throws IOException { + if (width <= 0 || height <= 0 || quality <= 0 || quality > 1.0) { + throw new IllegalArgumentException("Invalid parameters: width and height must be positive, quality must be between 0 and 1"); + } - File outputFile = new File(inputFile.getParent(), inputFile.getName()); + String fileName = inputFile.getName(); + String name = fileName.substring(0, fileName.lastIndexOf('.')); + String ext = fileName.substring(fileName.lastIndexOf('.')); + File outputFile = new File(inputFile.getParent(), name + "_resized" + ext); Thumbnails.of(inputFile) .size(width, height) .outputQuality(quality) .keepAspectRatio(true) .toFile(outputFile); return outputFile; }📝 Committable suggestion