Skip to content

refactor/#197 게시글 조회 시 미리보기 글자 수 조정#198

Merged
LeeHanEum merged 2 commits intodevelopfrom
refactor/#197-post-description-long
Feb 7, 2025
Merged

refactor/#197 게시글 조회 시 미리보기 글자 수 조정#198
LeeHanEum merged 2 commits intodevelopfrom
refactor/#197-post-description-long

Conversation

@LeeHanEum
Copy link
Copy Markdown
Member

@LeeHanEum LeeHanEum commented Feb 7, 2025

Summary

게시글 조회 시 미리보기 글자 수 조정

Tasks

  • 게시글 조회 시 미리보기 글자 수 조정
  • public endpoint에 carousel API 추가

To Reviewer

해당 브랜치로 배포 및 테스트 이후 merge 하겠습니다.

@LeeHanEum LeeHanEum self-assigned this Feb 7, 2025
Copilot AI review requested due to automatic review settings February 7, 2025 05:47
@LeeHanEum LeeHanEum linked an issue Feb 7, 2025 that may be closed by this pull request
1 task
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 7, 2025

Walkthrough

이 PR은 두 개의 Java 파일에 대한 수정 사항을 포함합니다. 하나는 사용자 게시물 요약 응답 클래스에서 게시물 내용의 부분 문자열 길이를 기존 30자에서 80자로 변경하여 설명 생성 로직을 수정한 것이고, 다른 하나는 보안 설정 클래스에서 공개 엔드포인트 목록에 “/api/v1/carousels” 엔드포인트를 추가한 것입니다.

Changes

파일 경로 변경 사항 요약
aics-api/.../PostSummaryResponse.java from 메소드에서 게시물 설명 문자열 생성 시 자르던 길이를 30자에서 80자로 확장함.
aics-common/.../SecurityConfig.java PUBLIC_ENDPOINTS 배열에 “/api/v1/carousels” 엔드포인트를 추가하여 인증 없이 접근 가능하도록 변경함.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f743a5 and 55c534d.

📒 Files selected for processing (2)
  • aics-api/src/main/java/kgu/developers/api/post/presentation/response/PostSummaryResponse.java (1 hunks)
  • aics-common/src/main/java/kgu/developers/common/config/SecurityConfig.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-docker-image
🔇 Additional comments (2)
aics-api/src/main/java/kgu/developers/api/post/presentation/response/PostSummaryResponse.java (1)

45-46: 미리보기 글자 수 조정이 적절히 구현되었습니다.

게시글 내용의 미리보기 길이를 80자로 늘린 변경이 잘 구현되었습니다. 이는 사용자에게 더 많은 컨텍스트를 제공할 수 있게 해줄 것입니다.

aics-common/src/main/java/kgu/developers/common/config/SecurityConfig.java (1)

85-85: 캐러셀 API의 공개 엔드포인트 추가가 적절합니다.

/api/v1/carousels 엔드포인트를 PUBLIC_ENDPOINTS에 추가한 것이 기존 패턴을 잘 따르고 있습니다. 이는 인증되지 않은 사용자도 캐러셀 데이터에 접근할 수 있게 해줄 것입니다.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2025

Test Coverage Report

Overall Project 95.74% 🍏

There is no coverage information present for the Files changed

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #198   +/-   ##
==========================================
  Coverage      92.99%   92.99%           
  Complexity       129      129           
==========================================
  Files             48       48           
  Lines            371      371           
  Branches           4        4           
==========================================
  Hits             345      345           
  Misses            21       21           
  Partials           5        5           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f743a5...55c534d. Read the comment docs.

Copy link
Copy Markdown
Contributor

@LeeShinHaeng LeeShinHaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
빠른 작업 좋습니다!!

@minjo-on
Copy link
Copy Markdown
Contributor

minjo-on commented Feb 7, 2025

LGTM😁

@LeeHanEum LeeHanEum merged commit f806df4 into develop Feb 7, 2025
6 checks passed
@LeeHanEum LeeHanEum deleted the refactor/#197-post-description-long branch February 7, 2025 11:42
@coderabbitai coderabbitai bot mentioned this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

게시글 조회 시 미리보기 description 글자 수 변경

4 participants