Skip to content

Commit b3b6157

Browse files
committed
Merge branch 'nfp-fixes'
Jakub Kicinski says: ==================== nfp: RX and XDP buffer fixes Two trivial fixes for code introduced with XDP support. First one corrects the buffer size we populate a register with. The register is designed to be used for scatter transfers which the driver (and most FWs) don't support so it's not critical. The other one for DMA direction is mostly cosmetic, DMA API doesn't seem to care today about the precise direction in sync calls. ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents e285998 + d58cebb commit b3b6157

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1498,7 +1498,7 @@ nfp_net_tx_xdp_buf(struct nfp_net *nn, struct nfp_net_rx_ring *rx_ring,
14981498
txbuf->real_len = pkt_len;
14991499

15001500
dma_sync_single_for_device(&nn->pdev->dev, rxbuf->dma_addr + pkt_off,
1501-
pkt_len, DMA_TO_DEVICE);
1501+
pkt_len, DMA_BIDIRECTIONAL);
15021502

15031503
/* Build TX descriptor */
15041504
txd = &tx_ring->txds[wr_idx];
@@ -1611,7 +1611,7 @@ static int nfp_net_rx(struct nfp_net_rx_ring *rx_ring, int budget)
16111611

16121612
dma_sync_single_for_cpu(&nn->pdev->dev,
16131613
rxbuf->dma_addr + pkt_off,
1614-
pkt_len, DMA_FROM_DEVICE);
1614+
pkt_len, DMA_BIDIRECTIONAL);
16151615
act = nfp_net_run_xdp(xdp_prog, rxbuf->frag + data_off,
16161616
pkt_len);
16171617
switch (act) {
@@ -2198,7 +2198,8 @@ static int __nfp_net_set_config_and_enable(struct nfp_net *nn)
21982198
nfp_net_write_mac_addr(nn);
21992199

22002200
nn_writel(nn, NFP_NET_CFG_MTU, nn->netdev->mtu);
2201-
nn_writel(nn, NFP_NET_CFG_FLBUFSZ, nn->fl_bufsz);
2201+
nn_writel(nn, NFP_NET_CFG_FLBUFSZ,
2202+
nn->fl_bufsz - NFP_NET_RX_BUF_NON_DATA);
22022203

22032204
/* Enable device */
22042205
new_ctrl |= NFP_NET_CFG_CTRL_ENABLE;

0 commit comments

Comments
 (0)