New overload OTSContext::Process to lower memory use processing WOFF2 #299
+185
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This patch is intrusive. It's not necessarily expected that this patch can land in its current state, rather it is provided to spur discussion. We are Chromium integrators and we've seen that processing some WOFF2 fonts can take up a lot of memory. This patch adds a new overload to OTSContext::Process in order to make it possible to use less memory while processing WOFF2 fonts. It does so via the following changes: - Makes ots::ExpandingMemoryStream part of public ots API. - Makes ots::ExpandingMemoryStream handle move-construct and move-assignment. - Adds an overload of ots::OTSContext::Process that takes an rvalue ref to ots::ExpandingMemoryStream as input buffer. - Makes ots::OTSContext::Process return the output buffer instead of writing to a separate output buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This patch is intrusive. It's not necessarily expected that this patch can land in its current state, rather it is provided to spur discussion.
We are Chromium integrators and we've seen that processing some WOFF2 fonts can take up a lot of memory. This patch adds a new overload to OTSContext::Process in order to make it possible to use less memory while processing WOFF2 fonts. It does so via the following changes:
Resolves #298