Implement PR feedback and update docs #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Drive opt-in. - Support -h/-help/--help across commands; document help usage. - Fix README repo path and clarify OneDrive env and setup. - Add .env.example placeholders and tidy variables. - Make OneDrive deps optional via lazy imports; clarify build src type. - Minor robustness in build: validate src, error on onedrive path until sync. - Ensure EPUB parsing lazy-imports ebooklib to speed tests.
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply feedback from PR #1, improving CLI help, documentation, and dependency handling for OneDrive and EPUB.
This PR addresses several points from PR #1, including:
-h,-help,--help) to all commands for better usability.README.mdand.env.exampleto clarify OneDrive setup and environment variables.ebookliband OneDrive-related dependencies (msgraph,azure.identity) to make them optional, reducing the initial dependency footprint.buildcommand's--srcoption to explicitly error when aonedrive:/path is provided, guiding users to sync files locally as direct processing is not yet supported.