Add file filter autocomplete for Obsidian chat (#1183)#1232
Open
shanto12 wants to merge 5 commits intokhoj-ai:masterfrom
Open
Add file filter autocomplete for Obsidian chat (#1183)#1232shanto12 wants to merge 5 commits intokhoj-ai:masterfrom
shanto12 wants to merge 5 commits intokhoj-ai:masterfrom
Conversation
- Added autocomplete suggestions for file: query filter in web chat - Fetches user's synced files from /api/content/files endpoint - Filters suggestions as user types more characters - Uses existing Command component pattern for consistent UX
Initial commit adding file filter autocomplete properties for Obsidian chat. This is part of implementing issue khoj-ai#1183 - Show autocomplete suggestions for File Query Filters in Chat on Obsidian App. Added: - fileFilterDropdown: HTMLElement property - fileFilterSuggestions: string[] for storing file list - selectedFileFilterIndex: number for dropdown navigation TODO: Add methods for showing/hiding dropdown and file: pattern detection in onChatInput()
Part of issue khoj-ai#1183 - Obsidian file filter autocomplete - fetchUserFiles(): Fetches list of user files from /api/content/files - hideFileFilterDropdown(): Hides the file filter dropdown
Part of issue khoj-ai#1183 - Obsidian file filter autocomplete Added showFileFilterDropdown() method that: - Fetches and caches user files from API - Filters files based on user input - Creates and positions dropdown above input - Handles file selection click events
Completes issue khoj-ai#1183 - Obsidian file filter autocomplete Modified onChatInput() to detect file: pattern using regex /file:(\S*)$/ - Shows file filter dropdown when pattern detected - Hides dropdown when pattern not present - Filters suggestions based on characters after file:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements file filter autocomplete for the Obsidian chat interface, as requested in issue #1183.
Changes
fileFilterDropdown,fileFilterSuggestions, andselectedFileFilterIndexproperties to track dropdown statefetchUserFiles()method to fetch files from/api/content/filesendpointshowFileFilterDropdown()method to display and position the autocomplete dropdownhideFileFilterDropdown()method to hide the dropdownonChatInput()to detectfile:pattern using regex/file:(\S*)$/and trigger autocompleteHow It Works
file:in the Obsidian chat input, the dropdown appears with a list of synced filesfile:, the suggestions are filteredfile:"selected_file"into the inputRelated Issues