Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
Having deinit to do a cancelation in this sense can arguably lead to unnecessary load and conflict of intrests.
If a task has been fired already, but the bag gets de-allocated, the task will be canceled.
Consider an update task that fetches data, and stores them on disk.
This task lives in a module
B, and the owner of the bag is moduleB.Having such a flow, and creating a bag to maintain the task will result in two possible scenarios:
B, moduleAper say.Going from
A->B, either task gets automatically canceled, or dependencies needs to be aligned to keep this task alive after the end of moduleB.