[MBL-2078] Add project chevron to PPO card #2634
Conversation
ifosli
requested review from
a team,
scottkicks and
stevestreza-ksr
and removed request for
a team and
scottkicks
stevestreza-ksr
left a comment
stevestreza-ksr
left a comment
There was a problem hiding this comment.
One minor thing left but otherwise no issues.
The chevron looks off to me being top-aligned, I would expect it to be centered relative to be centered relative to the rest of the stuff in project details. But that's a design thing. If that's what Alison wants then LGTM 👍
| .frame(width: Spacing.unit_04, height: Spacing.unit_04) | ||
| .padding(Spacing.unit_01) | ||
| .background(.clear) |
There was a problem hiding this comment.
Nit: Move these to PPOStyles
There was a problem hiding this comment.
Hmm, I actually don't think it makes sense to move these to PPOStyles in this case. The figma basically says the height and width of the icon should be 24 (ie unit 6 in the new spacing). However, the icon in the figma looks like it has built-in padding. To represent this, I shifted some of the icon width/height to be padding instead. I don't expect this to be true for the other icons (but I won't be sure until they're all added).
What do you think of leaving this as-is for now, and moving shared icon spacing into PPOStyles, if we end up actually having shared spacing?
Yeah, based on the v2 designs, I changed the whole project details cell to be top-aligned. I'll double-check with Alison or Tae before merging this, just in case these designs are out of date. |
📲 What
Add a chevron to the project details cell in PPO. This also edits the alignment of the project details to match designs. (It was previously centered and now it's top-aligned.)
👀 See
Jira
♿️ Accessibility
✅ Acceptance criteria