Skip to content

Conversation

@ifosli
Copy link
Contributor

@ifosli ifosli commented Sep 30, 2025

📲 What

We decided to have the project/project details/backing details cell on the PPO card open the project page instead of the backing details page. This change was done on android as part of v2 work, so this updates iOS to be in sync.

👀 See

Jira

Before 🐛 After 🦋
Simulator Screen Recording - iPhone 16 Pro Max - 2025-09-30 at 13 52 45 Simulator Screen Recording - iPhone 16 Pro Max - 2025-09-30 at 13 50 44

✅ Acceptance criteria

  • Project cell on PPO card now opens project page instead of survey/backing details.

@ifosli ifosli self-assigned this Sep 30, 2025
@ifosli ifosli changed the title Open project from PPO [MBL-2539] Open project from PPO project details cell Sep 30, 2025
@ifosli ifosli changed the title [MBL-2539] Open project from PPO project details cell [MBL-2539] Open project page from PPO project details cell Sep 30, 2025
@ifosli ifosli marked this pull request as ready for review September 30, 2025 20:00
@ifosli ifosli requested review from a team and amy-at-kickstarter and removed request for a team September 30, 2025 20:00
@nativeksr
Copy link
Collaborator

nativeksr commented Nov 25, 2025

SwiftLint found issues

Warnings

File Line Reason
PPOProjectCard.swift 11 Optional should be implicitly initialized without nil (implicit_optional_initialization)
PPOViewModel.swift 447 File should contain 400 lines or less: currently contains 447 (file_length)
PPOViewModel.swift 92 Class body should span 250 lines or less excluding comments and whitespace: currently spans 251 lines (type_body_length)
PPOContainerViewController.swift 14 Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)
PPOContainerViewController.swift 14 Function body should span 50 lines or less excluding comments and whitespace: currently spans 86 lines (function_body_length)
PPOContainerViewController.swift 170 Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
PPOContainerViewController.swift 181 Variable name 'vc' should be between 3 and 40 characters long (identifier_name)

Errors

File Line Reason
PPOViewModel.swift 93 Initializer body should span 100 lines or less excluding comments and whitespace: currently spans 178 lines (function_body_length)

Generated by 🚫 Danger

@ifosli ifosli merged commit 365cd9d into main Nov 25, 2025
5 checks passed
@ifosli ifosli deleted the openProjectFromPPO branch November 25, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants