Added support for parsing github-output vars#67
Open
im-sampm wants to merge 1 commit intokiegroup:mainfrom
Open
Added support for parsing github-output vars#67im-sampm wants to merge 1 commit intokiegroup:mainfrom
im-sampm wants to merge 1 commit intokiegroup:mainfrom
Conversation
shubhbapna
requested changes
Jan 12, 2024
Collaborator
shubhbapna
left a comment
shubhbapna
left a comment
There was a problem hiding this comment.
There some test cases failing, could you fix them and I will review it then. Furthermore, can you also write test cases for this?
TWiStErRob
reviewed
Feb 1, 2024
| * @param line | ||
| */ | ||
| private parseStepOutputs(line: string) { | ||
| const stepOutputsMatcher = /^\s*(\[.+\])\s*\u2699\s*::set-output::\s*(.*)=(.*)/; |
Contributor
There was a problem hiding this comment.
nice, if this gets done, we can generalize it to other side effects, e.g.:
[Android Build/Unit Tests] ✅ Success - Main Set up Java for Android SDK.
[Android Build/Unit Tests] ⚙ ::set-env:: JAVA_HOME=/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64
[Android Build/Unit Tests] ⚙ ::set-env:: JAVA_HOME_17_X64=/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64
[Android Build/Unit Tests] ⚙ ::set-output:: distribution=Temurin-Hotspot
[Android Build/Unit Tests] ⚙ ::set-output:: path=/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64
[Android Build/Unit Tests] ⚙ ::set-output:: version=17.0.10+7
[Android Build/Unit Tests] ⚙ ::add-path:: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.10-7/x64/bin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66