Fixed vulnerability for 0.10.1 release#345
Draft
soerendomroes wants to merge 2 commits intomasterfrom
Draft
Conversation
Member
|
I think it's fine, just a question why is the lockfile version being updated and shouldn't this then also happen on the master? Is this a result of building with a newer npm version or something like that? |
Member
|
And for the release, the built files in the lib folder need be force added to this branch |
Member
Author
I do not think that it matters since this branch will never be merged back. I am just changing the package.json and rebuilding. Everything else is handled by npm. Maybe since the version changed, the lockversion is reset to 1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge this.
@Eddykasp please review this. If you think it looks fine, I will continue with the release of elkjs 0.10.1.