-
Notifications
You must be signed in to change notification settings - Fork 13
Enabled use exhaustive dependencies rule #2681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sigrid maintainability feedbackShow detailsSigrid compared your code against the baseline of 2026-01-06. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2681 +/- ##
==========================================
- Coverage 91.87% 91.87% -0.01%
==========================================
Files 375 375
Lines 18951 18950 -1
Branches 1965 1965
==========================================
- Hits 17412 17411 -1
Misses 1446 1446
Partials 93 93 ☔ View full report in Codecov by Sentry. |
PDF Diff SummaryComparing against base branch:
|
stacktraceghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked every change. I had doubts about Feedback.tsx and checked this by starting an entry and causing errors on two pages. Then used the webdev toolbar with the live expression document.activeElement to see if the focus was set to the FeedbackHeader and it was.
Did not find any issues.
praseodym
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, did not test all changes
Closes #2669
I tested the changes and didn't notice any issues, please test elaborately when reviewing to confirm.