Skip to content

Conversation

@Lionqueen94
Copy link
Contributor

@Lionqueen94 Lionqueen94 commented Dec 29, 2025

Closes #2669

I tested the changes and didn't notice any issues, please test elaborately when reviewing to confirm.

@Lionqueen94 Lionqueen94 self-assigned this Dec 29, 2025
@Lionqueen94 Lionqueen94 added frontend Issues or pull requests that relate to the frontend tech debt Tech debt, potential refactorings labels Dec 29, 2025
@github-actions
Copy link

github-actions bot commented Dec 29, 2025

Sigrid maintainability feedback

↗️ You improved your code towards your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-01-06.

👍 What went well?

You fixed or improved 1 refactoring candidates.

Risk System property Location
🟠 Unit Interfacing
(Fixed)
frontend/src/features/data_entry/hooks/useInitialDataEntryState.ts
useInitialDataEntryState.ts.useInitialDataEntryState(ApiClient,DataEntryDispatch,Required<Election>,string,string)

👎 What could be better?

Unfortunately, 1 refactoring candidates were introduced or got worse.

Risk System property Location
🟡 Unit Interfacing
(Introduced)
frontend/src/features/data_entry/hooks/useInitialDataEntryState.ts
useInitialDataEntryState.ts.useInitialDataEntryState(ApiClient,DataEntryDispatch,string)

📚 Remaining technical debt

4 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-01-06 Before changes New/changed code
Volume 3.4 N/A N/A
Duplication 3.7 5.5 5.5
Unit Size 2.2 1.6 1.5
Unit Complexity 3.2 0.9 0.7
Unit Interfacing 2.9 2.1 4.2
Module Coupling 3.3 5.5 5.5
Component Independence 2.1 N/A N/A
Component Entanglement 2.3 N/A N/A
Maintainability 2.9 3.1 3.3

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.87%. Comparing base (3a04dd3) to head (9dd152c).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ures/data_entry/hooks/useFormKeyboardNavigation.ts 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   91.87%   91.87%   -0.01%     
==========================================
  Files         375      375              
  Lines       18951    18950       -1     
  Branches     1965     1965              
==========================================
- Hits        17412    17411       -1     
  Misses       1446     1446              
  Partials       93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lionqueen94 Lionqueen94 mentioned this pull request Dec 29, 2025
22 tasks
@Lionqueen94 Lionqueen94 changed the title Enabled use exhaustive dependencies rule WIP: Enabled use exhaustive dependencies rule Dec 30, 2025
@Lionqueen94 Lionqueen94 marked this pull request as ready for review January 6, 2026 11:58
@Lionqueen94 Lionqueen94 requested a review from a team as a code owner January 6, 2026 11:58
@Lionqueen94 Lionqueen94 changed the title WIP: Enabled use exhaustive dependencies rule Enabled use exhaustive dependencies rule Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PDF Diff Summary

Comparing against base branch: main

File Status
model-n-10-2.pdf ✅ No changes
model-na-14-2-bijlage1.pdf ✅ No changes
model-na-14-2.pdf ✅ No changes
model-na-31-2-bijlage1.pdf ✅ No changes
model-na-31-2-inlegvel.pdf ✅ No changes
model-na-31-2.pdf ✅ No changes
model-p-2a.pdf ✅ No changes

Copy link
Contributor

@stacktraceghost stacktraceghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked every change. I had doubts about Feedback.tsx and checked this by starting an entry and causing errors on two pages. Then used the webdev toolbar with the live expression document.activeElement to see if the focus was set to the FeedbackHeader and it was.

Did not find any issues.

Copy link
Contributor

@praseodym praseodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, did not test all changes

@Lionqueen94 Lionqueen94 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit 3db97d0 Jan 9, 2026
19 checks passed
@Lionqueen94 Lionqueen94 deleted the enable_use_exhaustive_dependencies_rule branch January 9, 2026 13:13
@github-project-automation github-project-automation bot moved this from In Progress to Done in Abacus Development Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Issues or pull requests that relate to the frontend tech debt Tech debt, potential refactorings

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Re-enable Biome rules

4 participants