Skip to content

Conversation

@Lionqueen94
Copy link
Contributor

Closes #2628

@Lionqueen94 Lionqueen94 self-assigned this Jan 6, 2026
@Lionqueen94 Lionqueen94 linked an issue Jan 6, 2026 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-01-06.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

You did not introduce any technical debt during your changes, great job!

📚 Remaining technical debt

7 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-01-06 Before changes New/changed code
Volume 3.4 N/A N/A
Duplication 3.7 5.5 5.5
Unit Size 2.2 1.5 1.5
Unit Complexity 3.2 5.5 5.5
Unit Interfacing 2.9 5.5 5.5
Module Coupling 3.3 N/A N/A
Component Independence 2.1 N/A N/A
Component Entanglement 2.3 N/A N/A
Maintainability 2.9 4.5 4.5

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

PDF Diff Summary

Comparing against base branch: main

File Status
model-n-10-2.pdf ✅ No changes
model-na-14-2-bijlage1.pdf ✅ No changes
model-na-14-2.pdf ✅ No changes
model-na-31-2-bijlage1.pdf ✅ No changes
model-na-31-2-inlegvel.pdf ✅ No changes
model-na-31-2.pdf ✅ No changes
model-p-2a.pdf ✅ No changes

@Lionqueen94 Lionqueen94 added tests Issues or pull requests that relate to tests tech debt Tech debt, potential refactorings labels Jan 6, 2026
@Lionqueen94 Lionqueen94 marked this pull request as ready for review January 6, 2026 16:33
@Lionqueen94 Lionqueen94 requested a review from a team as a code owner January 6, 2026 16:33
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.85%. Comparing base (3a04dd3) to head (9994cb8).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
backend/src/airgap/detect.rs 85.18% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
- Coverage   91.87%   91.85%   -0.03%     
==========================================
  Files         375      375              
  Lines       18951    18981      +30     
  Branches     1965     1967       +2     
==========================================
+ Hits        17412    17435      +23     
- Misses       1446     1452       +6     
- Partials       93       94       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lionqueen94 Lionqueen94 requested a review from praseodym January 6, 2026 16:46
@Lionqueen94 Lionqueen94 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into main with commit e2f1375 Jan 9, 2026
19 checks passed
@Lionqueen94 Lionqueen94 deleted the 2628-move-airgap_detection_testrs-from-tests-to-api branch January 9, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech debt Tech debt, potential refactorings tests Issues or pull requests that relate to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move airgap_detection_test.rs from /tests/ to api

4 participants