Apportionment structs/functions/tests#2787
Conversation
Sigrid maintainability feedback⏸️️ Your are still below your objective of 3.5 stars. Show detailsSigrid compared your code against the baseline of 2026-02-05. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2787 +/- ##
==========================================
- Coverage 91.38% 91.37% -0.01%
==========================================
Files 380 380
Lines 17661 17661
Branches 1987 1987
==========================================
- Hits 16139 16138 -1
Misses 1424 1424
- Partials 98 99 +1 ☔ View full report in Codecov by Sentry. |
|
@praseodym Should we already add the apportionment crate to |
Yes! |
b7bd452 to
2bcdcff
Compare
f5370eb to
e1df116
Compare
PDF Diff SummaryComparing against base branch:
|
Ruben will do an extra check and make improvements next week
Resolves #2766
Resolves #2767
Changes:
Brought back apportionment code
Adjusted structs
Reorganized code
PoliticalGrouptoListDisplayFractionto Abacus domain layerUpdated links to law articles
Added newtypes
Added apportionment crate to
sigrid.yamlMoved
backend/src/apportionment/*,frontendand otherbackendchanges to separate branch (bring_back_apportionment_api) for future epic.Not in scope: #2785