Skip to content

Move SQL queries out of the api layer#2863

Merged
oliver3 merged 1 commit intomainfrom
move-api-sql-queries
Feb 5, 2026
Merged

Move SQL queries out of the api layer#2863
oliver3 merged 1 commit intomainfrom
move-api-sql-queries

Conversation

@oliver3
Copy link
Contributor

@oliver3 oliver3 commented Feb 5, 2026

Even though it was used in the tests, there shouldn't be any SQL queries outside of the repository layer.

  • test_create_data_entry_uniqueness() now uses a new #[cfg(test)] get_polling_station_data_entries()
  • test_first_entry_finalise_with_errors() uses the existing audit_log::list_all() which has been changed to have a more intuitive ordering

@oliver3 oliver3 self-assigned this Feb 5, 2026
@oliver3 oliver3 requested a review from a team as a code owner February 5, 2026 15:25
@oliver3 oliver3 added the backend Issues or pull requests that relate to the backend label Feb 5, 2026
@oliver3 oliver3 moved this from Options to In Progress in Abacus Development Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Sigrid maintainability feedback

💭️ You did not change any files that are analyzed by Sigrid.


View this system in Sigrid

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

PDF Diff Summary

Comparing against base branch: main

File Status
model-n-10-2.pdf ✅ No changes
model-na-14-2-bijlage1.pdf ✅ No changes
model-na-14-2.pdf ✅ No changes
model-na-31-2-bijlage1.pdf ✅ No changes
model-na-31-2-inlegvel.pdf ✅ No changes
model-na-31-2.pdf ✅ No changes
model-p-2a.pdf ✅ No changes

Copy link
Contributor

@Lionqueen94 Lionqueen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.36%. Comparing base (ee1c92c) to head (a7e6273).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
- Coverage   91.37%   91.36%   -0.01%     
==========================================
  Files         379      379              
  Lines       17639    17659      +20     
  Branches     1987     1987              
==========================================
+ Hits        16117    16135      +18     
- Misses       1424     1425       +1     
- Partials       98       99       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliver3 oliver3 added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit c14433c Feb 5, 2026
20 checks passed
@oliver3 oliver3 deleted the move-api-sql-queries branch February 5, 2026 16:07
@github-project-automation github-project-automation bot moved this from In Progress to Done in Abacus Development Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Issues or pull requests that relate to the backend

Projects

Development

Successfully merging this pull request may close these issues.

3 participants