Skip to content

Add apportionment crate to Codecov code coverage#2866

Merged
praseodym merged 2 commits intomainfrom
codecov-apportionment
Feb 6, 2026
Merged

Add apportionment crate to Codecov code coverage#2866
praseodym merged 2 commits intomainfrom
codecov-apportionment

Conversation

@praseodym
Copy link
Contributor

@praseodym praseodym commented Feb 6, 2026

Add apportionment crate to Codecov code coverage by using the cargo llvm-cov nextest command to create the report.

The cargo llvm-cov report command needs additional crates to be specified manually, whereas the cargo llvm-cov nextest command that runs the tests with coverage can also create a report with all crates included.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Sigrid maintainability feedback

💭️ You did not change any files that are analyzed by Sigrid.


View this system in Sigrid

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.61%. Comparing base (df673ad) to head (bb193b4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
+ Coverage   91.35%   91.61%   +0.26%     
==========================================
  Files         380      389       +9     
  Lines       17661    18716    +1055     
  Branches     1987     2048      +61     
==========================================
+ Hits        16134    17147    +1013     
- Misses       1428     1467      +39     
- Partials       99      102       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Lionqueen94 Lionqueen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 👍
Image

@Lionqueen94
Copy link
Contributor

Somehow line by line coverage still does not show 🤔

image

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

PDF Diff Summary

Comparing against base branch: main

File Status
model-n-10-2.pdf ✅ No changes
model-na-14-2-bijlage1.pdf ✅ No changes
model-na-14-2.pdf ✅ No changes
model-na-31-2-bijlage1.pdf ✅ No changes
model-na-31-2-inlegvel.pdf ✅ No changes
model-na-31-2.pdf ✅ No changes
model-p-2a.pdf ✅ No changes

@praseodym
Copy link
Contributor Author

Somehow line by line coverage still does not show 🤔
image

Weird, let's see if it works after merging

@praseodym praseodym marked this pull request as ready for review February 6, 2026 15:36
@praseodym praseodym requested a review from a team as a code owner February 6, 2026 15:36
@Lionqueen94
Copy link
Contributor

Somehow line by line coverage still does not show 🤔
image

Weird, let's see if it works after merging

It works now that the branch is up to date with main 👍

@praseodym praseodym added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit af935ce Feb 6, 2026
19 checks passed
@praseodym praseodym deleted the codecov-apportionment branch February 6, 2026 16:03
@github-project-automation github-project-automation bot moved this from In Progress to Done in Abacus Development Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants