Skip to content

Conversation

@pohlm01
Copy link
Member

@pohlm01 pohlm01 commented Jan 22, 2026

And do a lot of other changes for the DB structure and some changes to the ownership during form validation

@pohlm01 pohlm01 linked an issue Jan 22, 2026 that may be closed by this pull request
@pohlm01 pohlm01 self-assigned this Jan 22, 2026
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars.

Show details

Sigrid compared your code against the baseline of 2026-01-26.

👍 What went well?

You fixed or improved 7 refactoring candidates.

Risk System property Location
🔴 Duplication
(Fixed)
src/candidate_lists/repository.rs line 107-112
src/candidate_lists/repository.rs line 134-139
🔴 Duplication
(Fixed)
src/candidate_lists/candidate_repository.rs line 58-72
src/candidate_lists/candidate_repository.rs line 99-113
🔴 Duplication
(Fixed)
src/candidate_lists/candidate_repository.rs line 95-113
src/candidate_lists/candidate_repository.rs line 147-165
🔴 Duplication
(Fixed)
src/persons/structs/person_form.rs line 89-97
src/persons/structs/person_form.rs line 103-111
🔴 Duplication
(Fixed)
src/candidate_lists/candidate_repository.rs line 58-77
src/candidate_lists/candidate_repository.rs line 151-170
🟠 Unit Size
(Fixed)
src/persons/structs/person_form.rs
PersonForm.build_person(PersonFormValidated,Option<&Person>)
🟡 Unit Size
(Fixed)
src/candidate_lists/structs/candidate_list_form.rs
CandidateListForm.build_candidate_list(CandidateListFormValidated,Option<&CandidateList>)

👎 What could be better?

Unfortunately, 62 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Duplication
(Introduced)
src/political_groups/repository.rs line 187-211
src/political_groups/repository.rs line 268-292
🔴 Duplication
(Introduced)
src/political_groups/repository.rs line 127-142
src/political_groups/repository.rs line 234-249
🔴 Duplication
(Introduced)
src/political_groups/repository.rs line 280-292
src/political_groups/repository.rs line 199-211
src/political_groups/repository.rs line 331-343
🔴 Duplication
(Introduced)
src/political_groups/repository.rs line 129-140
src/political_groups/repository.rs line 156-167
src/political_groups/repository.rs line 236-247
🔴 Duplication
(Introduced)
src/political_groups/structs/authorized_agent.rs line 10-23
src/political_groups/structs/list_submitter.rs line 10-23
🔴 Duplication
(Introduced)
src/candidate_lists/candidate_repository.rs line 59-73
src/candidate_lists/candidate_repository.rs line 100-114
🔴 Duplication
(Introduced)
src/political_groups/repository.rs line 51-61
src/political_groups/repository.rs line 97-107
🔴 Duplication
(Introduced)
src/political_groups/repository.rs line 158-167
src/political_groups/repository.rs line 333-342
src/political_groups/repository.rs line 269-278
+ 4 occurrences
⚫️ + 54 more

📚 Remaining technical debt

14 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid to explore your technical debt

⭐️ Sigrid ratings

System property System on 2026-01-26 Before changes New/changed code
Volume 5.5 N/A N/A
Duplication 4.1 3.3 2.4
Unit Size 3.0 2.3 2.0
Unit Complexity 4.8 5.5 5.5
Unit Interfacing 2.4 2.2 1.7
Module Coupling 4.3 2.7 3.7
Component Independence 3.1 N/A N/A
Component Entanglement 2.3 N/A N/A
Maintainability 3.8 3.4 3.5

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@pohlm01 pohlm01 force-pushed the 146-backend-code-for-algemene-lijstgegevens branch 2 times, most recently from a47c49a to b3011b7 Compare January 23, 2026 07:34
@marlonbaeten marlonbaeten force-pushed the 146-backend-code-for-algemene-lijstgegevens branch from b3011b7 to 0e2f81d Compare January 26, 2026 10:39
@marlonbaeten marlonbaeten assigned marlonbaeten and unassigned pohlm01 Jan 26, 2026
@marlonbaeten marlonbaeten force-pushed the 146-backend-code-for-algemene-lijstgegevens branch from 20f95af to 9770778 Compare January 26, 2026 15:32
pohlm01 and others added 3 commits January 26, 2026 19:36
And do a lot of other changes for the DB structure and some changes to the ownership during form validation
@marlonbaeten marlonbaeten force-pushed the 146-backend-code-for-algemene-lijstgegevens branch from 9770778 to c9720f0 Compare January 26, 2026 18:45
@marlonbaeten marlonbaeten force-pushed the 146-backend-code-for-algemene-lijstgegevens branch from c9720f0 to a914bc7 Compare January 26, 2026 20:03
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backend code for "Algemene lijstgegevens"

3 participants